Switch .dockerignore to whitelist-only approach#605
Open
akostadinov-bot[bot] wants to merge 2 commits into
Open
Switch .dockerignore to whitelist-only approach#605akostadinov-bot[bot] wants to merge 2 commits into
akostadinov-bot[bot] wants to merge 2 commits into
Conversation
akostadinov-bot
Bot
force-pushed
the
fix-dockerignore
branch
6 times, most recently
from
July 17, 2026 18:22
ae6e731 to
bb0d086
Compare
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
.dockerignore: switch to whitelist-only approach. The previous blocklist was too permissive — the production image contained .git (8.8MB), .env (with credentials), .idea, .circleci, coverage/ (with stale SimpleCov data from a developer's machine), and other artifacts. Dockerfile: stop pinning UBI to a specific minor version (was 9.6, latest is 9.8). Using ubi9:9 tracks the latest 9.x minor. CI config: change working_directory from /opt/app-root/src to /opt/app-root/src/ci so CircleCI checkout works even without .git in the image. Point bundler to the original vendor/bundle path to reuse cached and image gems. Assisted-By: claude-opus-4-6
akostadinov-bot
Bot
force-pushed
the
fix-dockerignore
branch
from
July 17, 2026 19:59
cbc9d85 to
1224d4a
Compare
akostadinov
approved these changes
Jul 17, 2026
Contributor
|
btw this is not tested, so I have to test it before merging. But wanted to get your opinion first. |
jlledom
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.dockerignorewas too permissive — the production image contained.git(8.8MB),.env(with credentials),.idea,.circleci,coverage/(with stale SimpleCov data from a developer's machine), and other artifacts.s2i,app,bin,config,db,lib,public,vendor,Gemfile*,config.ru,Rakefile)Context
Discovered while investigating why qlty coverage validation was failing — the CI builder image had a stale
coverage/.resultset.jsonwith paths from a developer's local machine (/home/dmayorov/...) baked in from a previousdocker build.Test plan
docker-buildCI job still passes (builds image and runsrails db:setup)🤖 Generated with Claude Code