Skip to content

fix: make resume download responses ephemeral #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lairwaves wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: make resume download responses ephemeral #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78a485f
fix: make resume download responses ephemeral
lairwaves Apr 8, 2026
eac3cfc
style: apply ruff formatting
lairwaves Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions apps/discord_bot/src/five08/discord_bot/cogs/crm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,8 @@ async def callback(self, interaction: discord.Interaction) -> None:
resource_id=self.resume_id,
)
await interaction.followup.send(
"❌ An unexpected error occurred while downloading the resume."
"❌ An unexpected error occurred while downloading the resume.",
ephemeral=True,
)


Expand Down Expand Up @@ -4624,13 +4625,15 @@ async def _download_and_send_resume(
discord_file = discord.File(file_buffer, filename=filename)

await interaction.followup.send(
f"📄 Resume for **{contact_name}**:", file=discord_file
f"📄 Resume for **{contact_name}**:", file=discord_file, ephemeral=True
)
return True

except EspoAPIError as e:
logger.error(f"Failed to download resume {resume_id}: {e}")
await interaction.followup.send(f"❌ Failed to download resume: {str(e)}")
await interaction.followup.send(
f"❌ Failed to download resume: {str(e)}", ephemeral=True
)
return False
Comment thread
lairwaves marked this conversation as resolved.

def _check_member_role(self, interaction: discord.Interaction) -> bool:
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_crm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1919,7 +1919,7 @@ async def test_download_and_send_resume_api_error(self, crm_cog, mock_interactio
)

mock_interaction.followup.send.assert_called_once_with(
"❌ Failed to download resume: API Error"
"❌ Failed to download resume: API Error", ephemeral=True
)

def test_role_id_cache_initializes_empty(self, jobs_cog):
Expand Down