Fix multi-command buttons losing navigation targets in BFS traversal#34
Merged
Conversation
Buttons with multiple Grid 3 commands (e.g. Jump.SetBookmark + Jump.To) were only processing the first command due to an early break. This caused pages like "04 ACTIONS - Main" and "06 LITTLE WORDS - Main" to appear as orphans despite being navigable from the home page. - Remove early break after first recognized command in the command loop - Add if (!semanticAction) guards to all switch cases so the first semantic action wins but subsequent commands still run - Ensure Jump.To always sets navigationTarget even when another command already set semanticAction - Result: 467/482 pages now reachable (up from ~400), "say" and other action verbs correctly discovered via BFS Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buttons with multiple Grid 3 commands (e.g. Jump.SetBookmark + Jump.To) were only processing the first command due to an early break. This caused pages like "04 ACTIONS - Main" and "06 LITTLE WORDS - Main" to appear as orphans despite being navigable from the home page.