Unit testing#38
Draft
atteggiani wants to merge 8 commits into
Draft
Conversation
…' to replace the temporary input file created from the 'replace_landsurface_with_*.py' scripts with the actual input path, by removing '.tmp' from the end.
…h replacement function to use, based on the value of the command line argument '--type'.
100% test coverage for hres_ic.py
Open
tmcadam
reviewed
Nov 5, 2024
tmcadam
left a comment
tmcadam
left a comment
There was a problem hiding this comment.
These are nice unit tests and the module is well broken down into functions. I like the use of mock and patch, it's limiting the tests to your own code, a nice way to test different input combinations.
Collaborator
Author
Thank you for the initial review @tmcadam! Great, then I'll continue with this and incorporate the latest updates. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit-testing functions written (with 100% coverage) for the
hres_ic.pybefore the latest merge, so it will need to be updated.The
hres_ic.pyscript was refactored to allow proper testing.The latest merge introduced changes to
hres_ic.pythat influence the refactoring and overall logic, that need to be properly addressed for testing (#36).Opening this PR so it might get used once unit tests are updated.