Skip to content

[RL] Fix GPT-OSS 20B dimension mismatch error in vLLM adapter by resolving intermediate_size fallback#4175

Open
susanbao wants to merge 2 commits into
mainfrom
sanbao/gptrl
Open

[RL] Fix GPT-OSS 20B dimension mismatch error in vLLM adapter by resolving intermediate_size fallback#4175
susanbao wants to merge 2 commits into
mainfrom
sanbao/gptrl

Conversation

@susanbao

@susanbao susanbao commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR fixes a dimension mismatch error for GPT-OSS 20B in the vLLM adapter. Previously, the adapter looked up moe_intermediate_size in the Hugging Face configuration, which resulted in None for dense models like GPT-OSS 20B. This change resolves the fallback by checking intermediate_size if moe_intermediate_size is not present.

FIXES: b/475304467

Tests

Tested manually by verifying the config generation logic with GPT-OSS 20B Hugging Face configuration.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/layers/moe.py 0.00% 1 Missing and 1 partial ⚠️
...t/integration/vllm/maxtext_vllm_adapter/adapter.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@susanbao susanbao requested a review from michelle-yooh as a code owner June 17, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant