[RL] Fix GPT-OSS 20B dimension mismatch error in vLLM adapter by resolving intermediate_size fallback#4175
Open
susanbao wants to merge 2 commits into
Open
[RL] Fix GPT-OSS 20B dimension mismatch error in vLLM adapter by resolving intermediate_size fallback#4175susanbao wants to merge 2 commits into
susanbao wants to merge 2 commits into
Conversation
…lving intermediate_size fallback
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a dimension mismatch error for GPT-OSS 20B in the vLLM adapter. Previously, the adapter looked up
moe_intermediate_sizein the Hugging Face configuration, which resulted inNonefor dense models like GPT-OSS 20B. This change resolves the fallback by checkingintermediate_sizeifmoe_intermediate_sizeis not present.FIXES: b/475304467
Tests
Tested manually by verifying the config generation logic with GPT-OSS 20B Hugging Face configuration.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.