Skip to content

[DECOUPLED-MODE] grpo_trainer: route goodput/vertex imports through gcloud_stub for decoupled #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 18, 2026
+6 −2
Merged

[DECOUPLED-MODE] grpo_trainer: route goodput/vertex imports through gcloud_stub for decoupled #4180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/maxtext/experimental/rl/grpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@

import transformers

from ml_goodput_measurement.src.goodput import GoodputRecorder
from maxtext.common.goodput import goodput as _goodput_module

GoodputRecorder = _goodput_module.GoodputRecorder

import maxtext as mt
from maxtext.configs import pyconfig
Expand All @@ -87,7 +89,7 @@
from maxtext.experimental.rl import grpo_input_pipeline
from maxtext.experimental.rl import grpo_utils
from maxtext.common.metric_logger import MetricLogger
from maxtext.common.vertex_tensorboard import VertexTensorboardManager
from maxtext.common.gcloud_stub import vertex_tensorboard_modules
from maxtext.utils import exceptions
from maxtext.utils import gcs_utils
from maxtext.utils import max_logging
Expand All @@ -98,6 +100,8 @@
from maxtext.utils import sharding
from maxtext.utils import train_utils

VertexTensorboardManager, _vertex_tb_is_stub = vertex_tensorboard_modules()

# pylint: disable=too-many-positional-arguments

# -----------------------------------------------------------------------------
Expand Down
Loading