Skip to content

Remove Rosenbrock-Euler and Ros2 methods#2015

Merged
zingale merged 4 commits into
AMReX-Astro:developmentfrom
BenWibking:remove-rosenbrock-euler
Jun 11, 2026
Merged

Remove Rosenbrock-Euler and Ros2 methods#2015
zingale merged 4 commits into
AMReX-Astro:developmentfrom
BenWibking:remove-rosenbrock-euler

Conversation

@BenWibking

@BenWibking BenWibking commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Removes the Rosenbrock-Euler and Ros2 methods. These are not performance-competitive for any networks.

The remaining Rosenbrock methods all have both stiff accuracy and stiffly accurate embedded error estimators (which Rosenbrock-Euler and Ros2 do not have).

@BenWibking BenWibking changed the base branch from main to development June 8, 2026 13:33
@BenWibking BenWibking requested a review from zingale June 10, 2026 20:00
@BenWibking BenWibking changed the title Remove Rosenbrock-Euler tableau Remove Rosenbrock-Euler and Ros2 methods Jun 10, 2026
@BenWibking

Copy link
Copy Markdown
Collaborator Author

@zingale This just removes the methods that were too slow to be useful for any network either of us have tested.

@zingale

zingale commented Jun 11, 2026

Copy link
Copy Markdown
Member

Removed ROS2 and Rosenbrock-Euler method descriptions.
@BenWibking

Copy link
Copy Markdown
Collaborator Author

can you update the docs? https://amrex-astro.github.io/Microphysics/docs/ode_integrators.html

Fixed.

@zingale zingale merged commit d76fd20 into AMReX-Astro:development Jun 11, 2026
34 checks passed
@BenWibking BenWibking deleted the remove-rosenbrock-euler branch June 11, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants