Remove Rosenbrock-Euler and Ros2 methods#2015
Merged
zingale merged 4 commits intoJun 11, 2026
Merged
Conversation
Collaborator
Author
|
@zingale This just removes the methods that were too slow to be useful for any network either of us have tested. |
Member
|
can you update the docs? |
Removed ROS2 and Rosenbrock-Euler method descriptions.
Collaborator
Author
Fixed. |
zingale
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Rosenbrock-Euler and Ros2 methods. These are not performance-competitive for any networks.
The remaining Rosenbrock methods all have both stiff accuracy and stiffly accurate embedded error estimators (which Rosenbrock-Euler and Ros2 do not have).