WCSim PMT tilt implemented on a per-PMT basis#25
Open
S81D wants to merge 3 commits into
Open
Conversation
S81D
commented
Jun 12, 2026
| G4ThreeVector PMTPosition_tilt(pmt_x_shift,pmt_y_shift,tilt_pmt_z_shift); | ||
|
|
||
| // only rotate the affected PMTs (ignore Top, Bottom, and ANNIE Hamamatsu PMTs) | ||
| if ((pmt_type == 3)||(pmt_type == 0 && panel_nr != 0)){ |
Author
There was a problem hiding this comment.
I kept the logic of only applying the angles to the affected PMT populations. This can probably be dropped however there's no reason to tilt the Top/Bottom/Hamamatsu PMTs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very similar to PR #24 that was closed, and includes PMT tilting + LAPPD changes by Yue. Rather than applying a global tilt angle to the WB + WM PMTs, I have added an additional column in
PMTPositions_Scan.txtwhere the user can edit the individual PMT tilt angles based on GoPro observations / other data analyses.Right now all affected PMT tilt values are set to 53 degrees, which is consistent with what James and I have used in our CC and NC cross section analyses.
There are two limitations that should be added but unfortunately I don't have a ton of time to address them - I will try my best to fix them either in this PR or in another in the future: