validate rowBytes and width overflow in avifImageRGBToYUV#3146
Open
uwezkhan wants to merge 1 commit intoAOMediaCodec:mainfrom
Open
validate rowBytes and width overflow in avifImageRGBToYUV#3146uwezkhan wants to merge 1 commit intoAOMediaCodec:mainfrom
uwezkhan wants to merge 1 commit intoAOMediaCodec:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added validation in avifImageRGBToYUV to make sure rowBytes and width are safe before processing.
What was the issue
The function was using rowBytes directly without checking if it was actually large enough for the given width and pixel size.
If rowBytes is smaller than expected, it can read past the buffer.
Also, width * pixelSize could overflow in some cases.
What I changed
Impact
This prevents out-of-bounds reads when invalid RGB input is passed.