ci: relocate Codecov config, pin actions, add concurrency - #12
Conversation
- Move .github/workflows/codecov.yml -> .github/codecov.yml. It is a Codecov config file (no on:/jobs:), so Actions parsed it as an invalid workflow and marked a failed run on every commit. The reusable upload-to-codecov.yml stays under workflows/. - Pin third-party actions off moving @main/@master refs to current stable tags (checkout@v7, setup-python@v6, upload-artifact@v7, download-artifact@v8, codecov-action@v7, auto-assign@v3, gh-action-pypi-publish@v1.14.0). - Add concurrency cancel-in-progress to the PR-triggered Tests and Linters workflows (not the scheduled slow one). - Pin ruff (ruff==0.15.20) in the lint workflow for reproducible results. CI-config only; no source changes.
|
Do you want to send this PR to RocketPy directly? We can then pull from RocketPy |
For sure and I will also submit the fixes for the other accelerated optimization issues. I am currently running benchmarks and tests. |
|
Yes, upstream first makes more sense than landing it here. Most of what this touches is inherited from RocketPy unchanged, so fixing it here just gives the next sync something to reconcile. Two things before it goes anywhere, though. I went back over the current CI while checking a review of this branch, and the parts this PR reorganises are not merely untidy, they are reporting success without doing the work. Written up with log evidence in #22:
The token part is specific to this repository and cannot be fixed upstream. The artifact race and the So I would rather split this: send the genuinely upstream parts to RocketPy, and keep a small ARP-only change for the token and anything else fork-specific. This branch is also four commits behind Happy to close this one and open the two replacements, or to rework it in place, whichever you prefer. |
|
Marking this draft rather than pushing more to it, for the reason you raised: most of what it touches is inherited from RocketPy, so fixing it here gives the next sync something to reconcile. It is also no longer mergeable against What I verified in the meantime, on run 30401988315, is that two of these are not untidiness but jobs reporting success while doing nothing. Written up with the log lines in #22: the Codecov upload fails on every run ( The split I plan, unless you would rather sequence it differently:
I will reopen this or replace it once the upstream side is in, so there is nothing to review here in the meantime. |
Hardens and fixes the GitHub Actions setup (CI-config only, no source changes).
.github/workflows/codecov.ymlis a Codecov configuration file (it has noon:/jobs:), so Actions treats it as an invalid workflow and records a failed run on every commit. Moved to.github/codecov.yml(content unchanged). The real reusable workflowupload-to-codecov.ymlcorrectly stays underworkflows/.@main/@masterrefs to current stable tags:checkout@v7,setup-python@v6,upload-artifact@v7,download-artifact@v8,codecov-action@v7,auto-assign@v3,gh-action-pypi-publish@v1.14.0(supply-chain / stability hygiene).concurrencycancel-in-progress to the PR-triggeredTestsandLintersworkflows so superseded runs are cancelled (deliberately not added to the scheduled slow workflow).ruff==0.15.20) in the lint workflow for reproducible results.Note:
mastercarries the same misplacedcodecov.yml; a release or cherry-pick clears the permanent failure there too.