Conversation
There was a problem hiding this comment.
Pull request overview
This PR restructures how environment-specific/private Spring configuration is provided to the application by introducing a Git submodule (ASSU_config) and a Gradle resource-copy step, while removing the previous application-secret.yml injection path from Docker/CI-CD.
Changes:
- Add
ASSU_configGit submodule and automatically copy its environment configs intosrc/main/resourcesduringprocessResources. - Update CI/CD workflows to checkout submodules (and remove
application-secret.ymlcreation/copy steps in CD). - Update Spring/Docker Compose configuration by disabling
spring.config.importforapplication-secret.ymland removing related container mounts/env settings.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/resources/application.yml |
Adds profile grouping/defaults and comments out external secret config import. |
docker-compose.yml |
Removes application-secret.yml mount and SPRING_CONFIG_ADDITIONAL_LOCATION. |
build.gradle |
Adds copyPrivateConfig and makes processResources depend on it. |
.gitmodules |
Adds ASSU_config submodule definition. |
.gitignore |
Ignores generated/copied application-*.yml files. |
.github/workflows/ci.yml |
Enables submodule checkout using a secret token. |
.github/workflows/cd.yml |
Enables submodule checkout and removes application-secret.yml handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
16
to
20
| - uses: actions/checkout@v4 | ||
| with: | ||
| submodules: true # 서브모듈 활성화 | ||
| token: ${{ secrets.ACTION_TOKEN }} # Private 서브모듈 접근용 토큰 | ||
|
|
Comment on lines
+22
to
+25
| # config: | ||
| # import: | ||
| # - optional:classpath:application-secret.yml | ||
| # - optional:file:/app/config/application-secret.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
🔎코드 설명(스크린샷(선택))
💬고민사항 및 리뷰 요구사항 (Optional)
비고 (Optional)