Skip to content

[Deploy] 서브모듈 설정#340

Merged
BAEK0111 merged 2 commits into
mainfrom
develop
May 18, 2026
Merged

[Deploy] 서브모듈 설정#340
BAEK0111 merged 2 commits into
mainfrom
develop

Conversation

@BAEK0111
Copy link
Copy Markdown
Contributor

@BAEK0111 BAEK0111 commented May 18, 2026

#️⃣연관된 이슈

#338

📝작업 내용

서브모듈 설정

🔎코드 설명(스크린샷(선택))

코드에 대한 설명을 작성해주세요.

💬고민사항 및 리뷰 요구사항 (Optional)

고민사항 및 의견 받고 싶은 부분 있으면 적어두기

비고 (Optional)

참고했던 링크 등 참고 사항을 적어주세요. 코드 리뷰하는 사람이 참고해야 하는 내용을 자유로운 형식으로 적을 수 있습니다.

Copilot AI review requested due to automatic review settings May 18, 2026 13:49
@BAEK0111 BAEK0111 changed the title Develop [Deploy] 서브모듈 설정 May 18, 2026
@BAEK0111 BAEK0111 self-assigned this May 18, 2026
@BAEK0111 BAEK0111 added the ✨ feature New feature or request label May 18, 2026
@BAEK0111 BAEK0111 merged commit 7a46f34 into main May 18, 2026
3 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures how environment-specific/private Spring configuration is provided to the application by introducing a Git submodule (ASSU_config) and a Gradle resource-copy step, while removing the previous application-secret.yml injection path from Docker/CI-CD.

Changes:

  • Add ASSU_config Git submodule and automatically copy its environment configs into src/main/resources during processResources.
  • Update CI/CD workflows to checkout submodules (and remove application-secret.yml creation/copy steps in CD).
  • Update Spring/Docker Compose configuration by disabling spring.config.import for application-secret.yml and removing related container mounts/env settings.

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/main/resources/application.yml Adds profile grouping/defaults and comments out external secret config import.
docker-compose.yml Removes application-secret.yml mount and SPRING_CONFIG_ADDITIONAL_LOCATION.
build.gradle Adds copyPrivateConfig and makes processResources depend on it.
.gitmodules Adds ASSU_config submodule definition.
.gitignore Ignores generated/copied application-*.yml files.
.github/workflows/ci.yml Enables submodule checkout using a secret token.
.github/workflows/cd.yml Enables submodule checkout and removes application-secret.yml handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment on lines 16 to 20
- uses: actions/checkout@v4
with:
submodules: true # 서브모듈 활성화
token: ${{ secrets.ACTION_TOKEN }} # Private 서브모듈 접근용 토큰

Comment on lines +22 to +25
# config:
# import:
# - optional:classpath:application-secret.yml
# - optional:file:/app/config/application-secret.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants