feat: add automated test workflow for certificate validation#11
Open
oto-macenauer-absa wants to merge 5 commits into
Open
feat: add automated test workflow for certificate validation#11oto-macenauer-absa wants to merge 5 commits into
oto-macenauer-absa wants to merge 5 commits into
Conversation
oto-macenauer-absa
requested review from
miroslavpojer and
ndivho-makhuvha
as code owners
There was a problem hiding this comment.
Pull request overview
Adds a CI workflow to exercise the composite validate-certificates action across multiple certificate validity scenarios on both Linux and macOS runners.
Changes:
- Introduces
.github/workflows/test.ymlto generate certificate fixtures at runtime and validate action behavior across 6 scenarios. - Updates
.gitignoreto exclude generated test fixtures (tests/fixtures/) from local working copies.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/test.yml |
New cross-platform workflow that generates cert fixtures and asserts expected outcomes/step-summary content for key scenarios. |
.gitignore |
Ignores runtime-generated test fixture directory to keep the repo clean for local runs. |
Comment on lines
+37
to
+40
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| with: | ||
| persist-credentials: false |
Collaborator
Author
There was a problem hiding this comment.
Even the referenced code clearly says actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd, nothing to fix here
oto-macenauer-absa
force-pushed
the
feat/add-test-workflow
branch
from
b529503 to
a93781c
Compare
oto-macenauer-absa
force-pushed
the
feat/add-test-workflow
branch
from
a93781c to
e05b006
Compare
The refactor that extracted inline bash to validate.sh dropped fail_on_warn support, output variable emissions, and the metrics table from the step summary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/test.ymlwith 6 test scenarios covering valid, expiring-soon, expired, not-yet-valid, missing file, and multi-cert with valid replacementopenssl reqandopenssl cafor date-controlled certsubuntu-latestandmacos-latestto catchdateportability regressionsCloses #6
Release Notes
Test plan