testing: speed up exr-decreasingy test#5121
Open
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
testing: speed up exr-decreasingy test#5121lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
This test did more than was really necessary. It resized a small image (twice) to get big images, but the contents didn't matter, so just using a gradient is good enough. Also, we can check results just by using the hash of the image contents, don't need to do extra idiff calls. It's barely noticeable on a regular release build, since the whole test was only a couple seconds on my laptop and maybe 15 seconds on the GH runnners. But for the CI "sanitize" test, this cuts about 30 seconds from this test! Every little bit helps, the sanitize tests are usually the last to complete in a CI run. Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test did more than was really necessary. It resized a small image (twice) to get big images, but the contents didn't matter, so just using a gradient is good enough. Also, we can check results just by using the hash of the image contents, don't need to do extra idiff calls.
It's barely noticeable on a regular release build, since the whole test was only a couple seconds on my laptop and maybe 15 seconds on the GH runners. But for the CI "sanitize" test, this cuts about 30 seconds from this test! Every little bit helps, the sanitize tests are usually the last to complete in a CI run.