feat(vdb_print): add VDB Point support (Issue #617)#2203
Conversation
|
|
|
Thank you for signing the CLA. We no longer support ABI<=6, so all the conditional branching related to that is not required any more. There is a fair amount more complexity here than I think is truly necessary. Let's only output detailed attribute and group information for shared descriptors. Let's remove out-of-core output as this is due to be removed soon anyway. Let's remove hex flag output - this output is intended to be human-readable. Let's not include both compression summary and full types and they are the same information. Can you provide an examples of what the tool output looks like? Preferably using a VDB Points grid with more than one attribute and a group. I think it should be fairly evident how to make the output more readable. Finally, the CMake build directories shouldn't be included as part of your PR. |
…on#617) Signed-off-by: Aleksandar Veljkovic <veljkovic.tech@gmail.com>
|
@danrbailey Thanks for the review and the guidance! I completely agree that the output needed to be simplified. I have pushed an update that addresses all of your points:
Here is a mock example of what the new output looks like for a Point grid with a shared descriptor, multiple attributes, and a group: Point data: And if the descriptor is not shared: Point data: Let me know if this formatting aligns better with the project's vision! |
I don't mind that this was implemented using AI coding, but we do need to see the actual output for real world data that gives us full confidence that this actually works, not mock output that the AI is generating. These good first issues are intended to help users get up to speed with the entire process of building the library, signing the CLA as well as doing authentic runtime testing and using human judgement that the quality of the code and results align with the goals outlined in the issue and the coding standards and conventions of the project. Otherwise, my time would be better spent using Claude to implement this myself than going back-and-forth reviewing your PR. |
|
@danrbailey I have successfully resolved the environment configuration hurdles on my end, built the modified executable locally against MSVC, and verified the output against the official Academy Software Foundation real-world As requested, the log formatting now cleanly handles the Here is the true runtime execution output from the compiled binary tracking over 20 million points: The updated logic has been pushed cleanly to the PR branch. I really appreciate your patience and strict guidance throughout this refinement workflow! |
|
Any news on this? @danrbailey |
Description
Addresses issue #617 by adding VDB Point grid support to the
vdb_printcommand-line utility.Changes Implemented
#if OPENVDB_ABI_VERSION_NUMBER >= 6as requested in the issue.printPointDataDetailsinopenvdb_cmd/vdb_print/main.ccto match verbose tree outputs (using section headers, two-space indentations, andutil::formattedIntfor counts).Notes for Maintainers
Please note: I do not currently have the full C++ build dependencies (such as Boost) configured locally on my environment. I am submitting this as a Draft PR so that the repository's automated CI/CD build pipelines can run the build verification and automated tests. Please let me know if any formatting or formatting alignments need to be adjusted!