chore(deps): update rspack and babel dependencies to latest versions#2090
chore(deps): update rspack and babel dependencies to latest versions#2090UnschooledGamer wants to merge 3 commits intoAcode-Foundation:mainfrom
Conversation
- Removed unused plugin: com.foxdebug.acode.rk.exec.proot - Updated @babel/core from ^7.28.5 to ^7.29.0 - Updated @babel/plugin-transform-runtime from ^7.28.5 to ^7.29.0 - Updated @babel/preset-env from ^7.28.5 to ^7.29.5 - Updated @babel/runtime from ^7.28.4 to ^7.29.2 - Updated @babel/runtime-corejs3 from ^7.28.4 to ^7.29.2 - Updated autoprefixer from ^10.4.22 to ^10.5.0 - Updated babel-loader from ^10.0.0 to ^10.1.1 - Updated css-loader from ^7.1.2 to ^7.1.4 - Updated mini-css-extract-plugin from ^2.9.4 to ^2.10.2 - Updated postcss-loader from ^8.2.0 to ^8.2.1 - Updated prettier from ^3.7.4 to ^3.8.3 - Updated prettier-plugin-java from ^2.7.7 to ^2.8.1 - Updated sass from ^1.94.2 to ^1.99.0 - Updated sass-loader from ^16.0.6 to ^16.0.8 - Updated ts-loader from ^9.5.4 to ^9.5.7 - Updated @codemirror/autocomplete from ^6.20.1 to ^6.20.2 - Updated @codemirror/lang-jinja from ^6.0.0 to ^6.0.1 - Updated @codemirror/lang-yaml from ^6.1.2 to ^6.1.3 - Updated @codemirror/language from ^6.12.2 to ^6.12.3 - Updated @codemirror/lint from ^6.9.5 to ^6.9.6 - Updated @codemirror/lsp-client from ^6.2.2 to ^6.2.3 - Updated @codemirror/search from ^6.6.0 to ^6.7.0 - Updated @codemirror/view from ^6.40.0 to ^6.42.1 - Updated acorn from ^8.15.0 to ^8.16.0 - Updated core-js from ^3.47.0 to ^3.49.0 - Updated dayjs from ^1.11.19 to ^1.11.20 - Updated dompurify from ^3.4.0 to ^3.4.2 - Updated filesize from ^11.0.13 to ^11.0.17 - Updated katex from ^0.16.39 to ^0.16.45 - Updated markdown-it-github-alerts from ^1.0.0 to ^1.0.1 - Updated mermaid from ^11.13.0 to ^11.14.0 - Updated mime-types from ^3.0.1 to ^3.0.2
Greptile SummaryThis PR upgrades rspack from v1 to v2 (
Confidence Score: 4/5Dependency updates are well-scoped and the rspack v2 migration shims are structurally correct; the two config choices worth double-checking are exportsPresence and the empty roots array. The upgrade applies the documented rspack v2 migration steps correctly. The exportsPresence: auto setting softens the stricter v2 default, which could let real missing-export bugs pass as warnings rather than build errors. The resolve.roots: [] change is the correct v2 default but will silently break any SCSS/CSS files that reference assets with server-relative paths. rspack.config.js — the new parser and resolve options warrant a quick review against the actual build output and stylesheet asset paths. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[rspack v2 build start] --> B{module.parser.javascript}
B --> C["exportsPresence: auto"]
C --> D{Is module strict ESM?}
D -->|Yes| E[Error on missing export]
D -->|No - CJS| F[Warning only - may be silent]
B --> G["requireAlias: false"]
G --> H["require calls bypass resolve.alias"]
A --> I{resolve config}
I --> J["roots: empty array"]
J --> K["Server-relative CSS paths no longer resolve to project root"]
A --> M[CSS/SCSS rule]
M --> N["type: javascript/auto before use array"]
N --> O[CssExtractRspackPlugin loader chain]
Reviews (1): Last reviewed commit: "chore: update dependencies" | Re-trigger Greptile |
| crypto: false, | ||
| }, | ||
| modules: ['node_modules', 'src'], | ||
| roots: [], |
There was a problem hiding this comment.
resolve.roots: [] disables server-relative path resolution
In rspack v1, resolve.roots defaulted to [context] so CSS url(/some/image.png) references resolved relative to the project root. Setting it to [] (the v2 default) removes that implicit root, meaning any existing SCSS/CSS that uses server-relative paths starting with / will now fail to resolve at build time. This is the correct v2 migration step, but if the project's stylesheets contain such paths they should be converted to relative paths (or roots should be restored to [context]) before landing this change.
There was a problem hiding this comment.
Its seemingly working fine as-is. It should just default to http://localhost/fonts/font.tff etc, if no roots have been given I think
There was a problem hiding this comment.
@greptile Its seemingly working fine as-is. It should just default to http://localhost/fonts/font.tff etc, if no roots have been given I think
There was a problem hiding this comment.
That's a fair point. When roots is empty, rspack won't attempt to resolve server-relative paths (/fonts/font.ttf) against the filesystem at build time — it leaves them as-is, and the browser resolves them against the origin at runtime (http://localhost/fonts/font.ttf). So there's no build failure, just a shift from static to runtime resolution.
If the project's assets are served correctly at those paths (which your testing confirms they are), this is working as intended. My concern was a build-time error scenario that doesn't apply here.
Tip: You can give me more context with [.greptile/rules.md](https://www.greptile.com/docs/code-review/custom-standards) so I get this right next time.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Check list