Skip to content

Earmark conjunctive combinators from the funding page - #131

Merged
AdamSpitz merged 3 commits into
devfrom
feature/conjunction-earmark
Aug 19, 2026
Merged

Earmark conjunctive combinators from the funding page#131
AdamSpitz merged 3 commits into
devfrom
feature/conjunction-earmark

Conversation

@AdamSpitz

Copy link
Copy Markdown
Owner

Summary

CauseStarter now mints a conjunctive (all) combinator as part of earmarking funds for a selected bundle of statements, then opens the existing pledge form against that CID.

  • Funding page: select ≥2 published statements → Earmark for all N selected.
  • ensureCombinatorPublished reuses the shared combinator CID when it already exists.
  • Implication-attester payment is skipped on this path so a NoteIntent is not blocked on pairwise arrows.
  • Removed the generic cause-page Promote as any / all buttons. Combinators are created from the action that needs them.
  • Founder notes record which operator belongs to which job (any is still Ask — do not auto-mint from bridges).

Test plan

  • Open a cause with ≥2 published planks → funding page.
  • Single-plank Make a pledge still goes to /delegation/notes/new?statement=<plank>.
  • Check two planks, earmark: first time publishes the combinator (wallet txs), then lands on the pledge form with the combinator CID.
  • Repeat the same pair: no republish, same CID.
  • Cause page view strip no longer shows Promote buttons.
  • Disconnected wallet: earmark asks to connect instead of starting a publish.

Review gate: run /code-review --comment and scripts/post-review.sh before merge (project workflow).

Mint the all-of-these statement as part of pledging a selected bundle, skip republish when that CID already exists, and drop the generic cause-page Promote buttons.
The pledge targets the combinator CID; paying for pairwise arrows is a later graph job and must not fail the funding path after the statement already exists.
The "what exists" bullet still described generic cause-page promote.

@AdamSpitz AdamSpitz left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review receipt.

Conjunction earmark from funding page is the right operator/job split. Reuse via ensureCombinatorPublished + sorted CIDs is correct; skipping attester payment on this path is documented and matches NoteIntent needs. Fixed stale founder 'what exists' blurb that still described generic cause-page promote. Remaining any-mint path is already Ask on causestarter/TODO.md.

Reviewed-with: grok
Reviewed-files: 9
Reviewed-commit: 7e84e8d

@AdamSpitz
AdamSpitz merged commit cd3660d into dev Aug 19, 2026
3 checks passed
@AdamSpitz
AdamSpitz deleted the feature/conjunction-earmark branch August 19, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant