Runout issue fixed#4
Open
crazy4cricket2807 wants to merge 1 commit into
Open
Conversation
Owner
|
Hi, I'm sorry I haven't had time to look at your pull request till now. |
Author
|
No problem pal
crazy4cricket2807
…On Wed, Sep 7, 2022 at 3:37 AM Aducj1910 ***@***.***> wrote:
Hi, I'm sorry I haven't had time to look at your pull request till now.
I'll try to find some time and review it in the next few days.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AREIM2Z3IVVBQQZ546YSGFTV466DFANCNFSM57ZBW3PQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Aducj1910
requested changes
Sep 14, 2022
Owner
Aducj1910
left a comment
Aducj1910
left a comment
There was a problem hiding this comment.
What does commenting out the lambda function achieve? It exists in order to sort the batting order by positionAvg.
Aducj1910
requested changes
Sep 14, 2022
Owner
Aducj1910
left a comment
Aducj1910
left a comment
There was a problem hiding this comment.
What does commenting out the lambda function achieve? It exists in order to sort the batting order by positionAvg.
Author
|
But sometimes you won't need to sort via position average. I can adjust the
batting order accordingly, feel free to discard this change though
Just check the runout issue, the I have fixed that bug
…On Wed, 14 Sep, 2022, 09:21 Aducj1910, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
What does commenting out the lambda function achieve? It exists in order
to sort the batting order by positionAvg.
—
Reply to this email directly, view it on GitHub
<#4 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AREIM2Y772YWDXCBX5Q6LU3V6FDURANCNFSM57ZBW3PQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runout issues has been fixed in the updated code