fix(client): raise auth exception synchronously in Client.init()

[xodn348]

Summary

Fixes #1336 — Client.init() silently succeeds with an invalid API key.

Root cause: _start_auth_task() fired authentication off in a background daemon thread without joining. Any exception raised by fetch_auth_token (e.g. InvalidApiKeyException) was swallowed inside the thread, so init() unconditionally set _initialized = True and returned a session object even when the key was wrong.

Changes:

• agentops/client/api/versions/v3.py — fetch_auth_token now raises InvalidApiKeyException (instead of returning None) when the server returns no token or the HTTP request fails, so callers get a typed, informative error.
• agentops/client/client.py — _fetch_auth_async no longer wraps the whole body in a blanket except Exception: return None; exceptions propagate naturally. _start_auth_task in synchronous contexts (no running event loop) now joins the auth thread and re-raises any exception, surfacing failures immediately to init().
• Tests — Updated fetch_auth_token mocks from MagicMock.return_value = dict to AsyncMock(return_value=dict) since the method is async. Also fixed the wrong patch target in test_session.py (agentops.client.api.ApiClient → agentops.client.client.ApiClient). Added assert not client.initialized to the invalid-key test.

Before:

import agentops
agentops.init(api_key="not-a-real-key")  # succeeds silently, _initialized=True

After:

import agentops
agentops.init(api_key="not-a-real-key")
# raises: InvalidApiKeyException: API Key is invalid: {not-a-real-key}.
#         Find your API key at https://api.agentops.ai/settings/projects

Note on async callers: When init() is called from inside a running event loop, the auth task is still scheduled as a background asyncio.Task (blocking would deadlock the loop). This is an inherent limitation of mixing sync/async init; a future improvement could make init() itself async or expose an await client.verify_auth() helper.

Local test output

=== LOCAL_TEST_PASSED ===
tests/integration/test_auth_flow.py::test_auth_flow PASSED
tests/integration/test_auth_flow.py::test_auth_flow_invalid_key PASSED
tests/unit/test_session.py (21 tests) PASSED
24 passed in 0.84s
=== LOCAL_TEST_PASSED ===

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 42e3415196

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Propagate auth failures when an event loop is running

When init() is called from an async context such as an ASGI startup hook or notebook, this branch only schedules _fetch_auth_async() and returns, so any InvalidApiKeyException raised by fetch_auth_token() stays on the background task while init() continues and later marks the client initialized. This means the new synchronous auth failure behavior still does not apply in running-loop environments, and invalid credentials can be silently accepted until export fails.

Useful? React with 👍 / 👎.