fix(agent): Claude carries skills for project-local materialization#4825
Conversation
My earlier #4824 added a ClaudeAgentConfig.wire_skills override returning {} (graceful-degrade), but that contradicts the authoritative behavior from 08212c6 (fix(agent): materialize skills for Claude harness): the runner materializes skills under .claude/skills/<name>, so Claude carries them on the wire. The override broke the SDK unit test test_claude_carries_skills_for_project_local_materialization. Remove the override (Claude inherits the base wire_skills) and update the stale services-test assertion to expect Claude carries the skill. Claude-Session: https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Symptom
After #4824 merged, run-sdk-unit-tests failed:
test_claude_carries_skills_for_project_local_materializationgotKeyError: 'skills'fromclaude_cfg.wire_skills().Root cause
#4824 restored a
ClaudeAgentConfig.wire_skillsoverride returning{}(graceful degrade). That assumption is stale: commit08212c6dca(fix(agent): materialize skills for Claude harness, already on big-agents) made the runner materialize skills under.claude/skills/<name>, so Claude does carry them on the wire. The override fixed the stale services-test assertion but broke the authoritative SDK test.The
main→big-agentsmerge left the two tests contradicting each other; #4824 picked the wrong side.Fix
ClaudeAgentConfig.wire_skillsoverride; Claude inherits the base seam and carries resolved inline skill packages.test_invoke_handlerassertion to expect Claude carries the skill (aligned with the SDK test and the runner materializer).Verification
oss/tests/pytest/unit/agents: 319 passed.test_invoke_handler.py: 13 passed.https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT