Skip to content

fix(agent): Claude carries skills for project-local materialization#4825

Merged
mmabrouk merged 1 commit into
big-agentsfrom
fix/agent-claude-skills-materialize
Jun 24, 2026
Merged

fix(agent): Claude carries skills for project-local materialization#4825
mmabrouk merged 1 commit into
big-agentsfrom
fix/agent-claude-skills-materialize

Conversation

@mmabrouk

Copy link
Copy Markdown
Member

Symptom

After #4824 merged, run-sdk-unit-tests failed: test_claude_carries_skills_for_project_local_materialization got KeyError: 'skills' from claude_cfg.wire_skills().

Root cause

#4824 restored a ClaudeAgentConfig.wire_skills override returning {} (graceful degrade). That assumption is stale: commit 08212c6dca (fix(agent): materialize skills for Claude harness, already on big-agents) made the runner materialize skills under .claude/skills/<name>, so Claude does carry them on the wire. The override fixed the stale services-test assertion but broke the authoritative SDK test.

The mainbig-agents merge left the two tests contradicting each other; #4824 picked the wrong side.

Fix

  • Remove the ClaudeAgentConfig.wire_skills override; Claude inherits the base seam and carries resolved inline skill packages.
  • Update the stale test_invoke_handler assertion to expect Claude carries the skill (aligned with the SDK test and the runner materializer).

Verification

  • SDK oss/tests/pytest/unit/agents: 319 passed.
  • Services test_invoke_handler.py: 13 passed.

https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT

My earlier #4824 added a ClaudeAgentConfig.wire_skills override returning
{} (graceful-degrade), but that contradicts the authoritative behavior
from 08212c6 (fix(agent): materialize skills for Claude harness): the
runner materializes skills under .claude/skills/<name>, so Claude carries
them on the wire. The override broke the SDK unit test
test_claude_carries_skills_for_project_local_materialization.

Remove the override (Claude inherits the base wire_skills) and update the
stale services-test assertion to expect Claude carries the skill.

Claude-Session: https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Jun 24, 2026 5:44pm

Request Review

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working python Pull requests that update Python code labels Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 095e160f-6cee-4cd7-9bca-9aa366f372a2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/agent-claude-skills-materialize

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mmabrouk mmabrouk merged commit a9ecdc1 into big-agents Jun 24, 2026
22 of 27 checks passed
@mmabrouk mmabrouk deleted the fix/agent-claude-skills-materialize branch June 24, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant