test(agent): align acceptance/integration tests with agent refactors#4826
Conversation
These suites were skipped while the web build was broken; once it passed they ran and surfaced pre-existing drift on big-agents: - sdk acceptance: the agent builtin now ships a registered interface (no in-process handler), so test_agent_alias_is_not_registered was stale. Renamed to assert the interface is registered and the handler is absent. - services integration: gateway/secret resolution moved into the SDK platform package (#4772), so the agent_api_base/request_authorization/ httpx/log module attributes the conftest patched no longer exist on the service shims. Patch the SDK platform connection derivation helpers and the SDK platform module httpx/log instead. Claude-Session: https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dosubot
Bot
added
size:XS
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Railway Preview Environment
Updated at 2026-06-24T19:21:14.909Z |
1 participant
Symptom
The acceptance + integration test suites were skipped on #4791 while the agenta-web build was broken. Once #4822 fixed the build, they ran and surfaced pre-existing drift on big-agents:
test_agent_alias_is_not_registeredfailed — the agent builtin now ships a registered interface.AttributeError: ... has no attribute 'agenta_api_base'.Root cause
Two agent refactors already on big-agents weren't reflected in these tests:
agenta:builtin:agent:v0) registers an interface (schemas) but no in-process handler — it runs in the sidecar. The old test asserted it was fully unregistered.oss/src/agent/tools/{gateway,secrets}.pyandoss/src/agent/secrets.pyare now thin re-export shims, so the module-levelagenta_api_base/request_authorization/httpx/logthe tests patched no longer exist on them.Fix (tests only)
PlatformConnection's_derive_base_url/_derive_authorizationhelpers, and patchhttpx/logon the SDK platformgateway/secretsmodules (where the resolvers actually run). Test intent preserved; no tests deleted.Verification
test_new_uri_handlers.py: 27 passed.integration/agent: 15 passed.https://claude.ai/code/session_01DEZYALzKjh9ocjkscaBWRT