Make git_cacher resilient to connection timeouts#1221
Merged
Conversation
GiteaClient.make_request only caught ClientConnectorError and ServerDisconnectedError, so a ConnectionTimeoutError (or any other ClientConnectionError subclass) propagated up, cancelled the asyncio.gather in git_cacher.run, killed the process and triggered a container restart loop. - Broaden the retry catch to aiohttp.ClientConnectionError and asyncio.TimeoutError so timeouts are retried like other transient network errors. - Return [] explicitly after exhausting retries; the function used to fall off the end and return None, which crashed the caller with TypeError on items.extend(None). - Use return_exceptions=True on the gather calls in git_cacher so a single bad repo or organization is skipped instead of taking the whole cacher down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GiteaClient.make_request only caught ClientConnectorError and ServerDisconnectedError, so a ConnectionTimeoutError (or any other ClientConnectionError subclass) propagated up, cancelled the asyncio.gather in git_cacher.run, killed the process and triggered a container restart loop.