Skip to content

Antalya 25.8 Backport of #91853 - Fix logical error with join_use_nulls and cross join - #2190

Open
mkmkme wants to merge 1 commit into
antalya-25.8from
backports/antalya-25.8/91853
Open

Antalya 25.8 Backport of #91853 - Fix logical error with join_use_nulls and cross join#2190
mkmkme wants to merge 1 commit into
antalya-25.8from
backports/antalya-25.8/91853

Merge pull request #91853 from ClickHouse/vdimir/issue_87016_unexpect…

f0447c0
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Aug 8, 2026 in 1s

Check failed

All commits are incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🔴 f0447c0 Merge pull request ClickHouse#91853 from ClickHouse/vdimir/i... Sign-off not found

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Option 2: fix commits without sign-off

Amend last commit

To fix the incorrectly signed off commit:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git commit --amend --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin backports/antalya-25.8/91853