Skip to content

Fix/wcag issues on singing list and signee list#4305

Merged
phlipsterit merged 4 commits into
mainfrom
fix/wcag-issues-on-singing-list-and-signee-list
Jun 26, 2026
Merged

Fix/wcag issues on singing list and signee list#4305
phlipsterit merged 4 commits into
mainfrom
fix/wcag-issues-on-singing-list-and-signee-list

Conversation

@Magnusrm

@Magnusrm Magnusrm commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description

fixes overflowing content in the tables for SigneeList and SigningDocumentList when using 400% zoom.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Summary by CodeRabbit

  • Style
    • Table cells now wrap long content to prevent overflow and improve readability
    • State tag width constraints improved for better layout control
    • Download link spacing and vertical alignment refined for better visual consistency

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fc1d7953-c1a9-407b-8c76-c315911eac44

📥 Commits

Reviewing files that changed from the base of the PR and between ad2d9b4 and 9c48e5e.

📒 Files selected for processing (2)
  • src/app-components/Table/Table.module.css
  • src/layout/SigningDocumentList/SigningDocumentListComponent.module.css
💤 Files with no reviewable changes (1)
  • src/app-components/Table/Table.module.css

📝 Walkthrough

Walkthrough

Four CSS-only changes address WCAG 1.4.10 reflow accessibility: overflow-wrap: break-word is added to shared table body and header cells; a new .stateTag CSS module class with max-width: 100% is created and applied to the Tag component in SigneeStateTag; and .downloadLink in SigningDocumentListComponent switches to a CSS variable gap and adds align-items: center, removing white-space: nowrap.

Changes

CSS Reflow Accessibility Fixes

Layer / File(s) Summary
Table cell overflow-wrap
src/app-components/Table/Table.module.css
Adds overflow-wrap: break-word to .table tr td and .table tr th so long cell content wraps instead of overflowing.
SigneeList state tag constraint and SigningDocumentList download link alignment
src/layout/SigneeList/SigningStateTag.module.css, src/layout/SigneeList/SigneeStateTag.tsx, src/layout/SigningDocumentList/SigningDocumentListComponent.module.css
Creates .stateTag with max-width: 100% and applies it to Tag via className; updates .downloadLink to use var(--ds-size-1) gap and align-items: center, removing white-space: nowrap.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

  • #18952 (WCAG brudd: 1.4.10 Dynamisk tilpasning — SigningDocumentList): The .downloadLink flex alignment changes directly address the reflow accessibility issue identified for SigningDocumentList.
  • #4277 (WCAG brudd: 1.4.10 Dynamisk tilpasning — SigneeList): The .stateTag max-width: 100% constraint and table cell overflow-wrap changes address the reflow issue identified for SigneeList.

Possibly related PRs

  • Altinn/app-frontend-react#4288: Directly works on SigningDocumentListComponent and the downloadLink class, making it the immediate predecessor to the .downloadLink flex alignment update in this PR.

Suggested labels

squad/utforming

Suggested reviewers

  • walldenfilippa
  • lassopicasso
  • olavflar
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: fixing WCAG accessibility issues on the signing list and signee list components.
Description check ✅ Passed The description comprehensively covers the issue, provides linked issue references, and documents verification/QA with appropriate checkboxes marked for CSS-only changes requiring manual and WCAG testing.
Linked Issues check ✅ Passed The PR addresses both linked WCAG 1.4.10 Reflow violations through CSS layout fixes to prevent content overflow at 400% zoom in SigneeList and SigningDocumentList components.
Out of Scope Changes check ✅ Passed All changes are scoped to CSS modifications addressing the identified WCAG reflow issues; no unrelated functionality or logic changes are present in the PR.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/wcag-issues-on-singing-list-and-signee-list

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Magnusrm Magnusrm added the backport This PR should be cherry-picked onto older release branches label Jun 22, 2026
@Magnusrm Magnusrm marked this pull request as ready for review June 22, 2026 09:02

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/layout/SigningDocumentList/SigningDocumentListComponent.tsx`:
- Line 86: The downloadButton class used in SigningDocumentListComponent is
currently being imported from the wrong CSS module
(SigneeListComponent.module.css). Create a new dedicated CSS module file at
src/layout/SigningDocumentList/SigningDocumentListComponent.module.css and move
the downloadButton class definition there from the SigneeList module. Then
update the import statement in SigningDocumentListComponent.tsx (currently
importing from SigneeListComponent.module.css) to import from the new
SigningDocumentListComponent.module.css file to properly scope the CSS and
remove the undocumented coupling between components.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ea438631-519f-41e0-afac-bb7e77c72f95

📥 Commits

Reviewing files that changed from the base of the PR and between 7d8e4d1 and ad2d9b4.

📒 Files selected for processing (5)
  • src/app-components/Table/Table.module.css
  • src/layout/SigneeList/SigneeListComponent.module.css
  • src/layout/SigneeList/SigneeStateTag.tsx
  • src/layout/SigneeList/SigningStateTag.module.css
  • src/layout/SigningDocumentList/SigningDocumentListComponent.tsx

Comment thread src/layout/SigningDocumentList/SigningDocumentListComponent.tsx Outdated
@Magnusrm Magnusrm added the kind/bug Something isn't working label Jun 22, 2026
@Magnusrm Magnusrm moved this to 🔎 In review in Team Altinn Studio Jun 22, 2026
Comment thread src/app-components/Table/Table.module.css Outdated
@Magnusrm Magnusrm requested a review from phlipsterit June 23, 2026 15:08
@Magnusrm Magnusrm assigned phlipsterit and unassigned Magnusrm Jun 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

@phlipsterit phlipsterit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@phlipsterit phlipsterit assigned Magnusrm and unassigned phlipsterit Jun 24, 2026
@phlipsterit phlipsterit enabled auto-merge (squash) June 26, 2026 10:36
@phlipsterit phlipsterit merged commit a6a121f into main Jun 26, 2026
15 of 16 checks passed
@phlipsterit phlipsterit deleted the fix/wcag-issues-on-singing-list-and-signee-list branch June 26, 2026 10:37
@github-project-automation github-project-automation Bot moved this from 🔎 In review to ✅ Done in Team Altinn Studio Jun 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Automatic backport successful!

A backport PR has been automatically created for the release/v4.32 release branch.

The release branch release/v4.32 already existed and was updated.

The cherry-pick was clean with no conflicts. Please review the backport PR when it appears.

Magnusrm added a commit that referenced this pull request Jun 29, 2026
* fix overflow on apptable and download button in signingdocumentlist

* fix signeelist status-tag in 400% zoom

* re-apply word-break fix after merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR should be cherry-picked onto older release branches kind/bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

WCAG brudd: 1.4.10 Dynamisk tilpasning (Reflow) (AA): SigneeList WCAG brudd: 1.4.10 Dynamisk tilpasning (Reflow) (AA): SigningDocumentList

2 participants