[Backport] fix: Add accessible name to cancel signing dialog#4315
Open
github-actions[bot] wants to merge 1 commit into
Open
[Backport] fix: Add accessible name to cancel signing dialog#4315github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
* fix: Improve accessibility by adding aria-labelledby to reject modal heading * fix: Enhance accessibility by setting autofocus on reject modal heading * Better spacing of the buttons * fix: Improve accessibility by adding aria-describedby to reject modal heading * Update text of reject signing modal
phlipsterit
approved these changes
Jun 26, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Backport of #4296
This is an automated backport of PR #4296 to the
release/v4.32release branch.Original PR
Changes
Cherry-picked the merge commit from the original PR onto the release branch.
🤖 This backport PR was created automatically by the Auto Backport workflow.