Skip to content

Merge main into beta to resolve conflicts#79

Merged
TrevorSchirmer merged 13 commits into
betafrom
fix/merge-main-into-beta
Apr 19, 2026
Merged

Merge main into beta to resolve conflicts#79
TrevorSchirmer merged 13 commits into
betafrom
fix/merge-main-into-beta

Conversation

@bharvey88
Copy link
Copy Markdown
Contributor

@bharvey88 bharvey88 commented Apr 17, 2026

Summary

Files resolved

  • Integrations/ESPHome/Core.yaml — kept beta + patched LED count from main
  • Integrations/ESPHome/MSR-1_BLE.yaml — kept beta (already includes logger from main)

Summary by CodeRabbit

  • Chores
    • Updated CI/CD automation: workflow actions and build input selection adjusted to streamline builds and repository checkout.
    • Updated automation assignment settings.
    • Optimized device integration: LED configuration reduced and timing adjusted for improved behavior, and logging configuration moved earlier for more consistent startup diagnostics.

TrevorSchirmer and others added 12 commits July 18, 2025 12:32
1. Existing code has MSR-1 as having 3 LEDs in the strip. Corrected this to 1.

2. Proposing a default rmt_symbols value of 48. This is not strictly needed, but helps anyone adding a second LED strip from having to extend the "RGB Light" entity. 48 is the only real choice due to ESP32-C3's limit of 92 symbols, assignable in 48-symbol chunks (so it might as well be a default, as adding another RMT LED would require that one to be 48 as well).
Fixed number of LEDs in the "RGB Light" entity  to 1
Fixed firmware building
…andon

Change auto-assign assignee from TrevorSchirmer to bharvey88
…dates

Bumps the github-actions group with 2 updates in the / directory: [pozil/auto-assign-issue](https://github.com/pozil/auto-assign-issue) and [actions/checkout](https://github.com/actions/checkout).


Updates `pozil/auto-assign-issue` from 1 to 2
- [Release notes](https://github.com/pozil/auto-assign-issue/releases)
- [Commits](pozil/auto-assign-issue@v1...v2)

Updates `actions/checkout` from 4.2.2 to 5.0.0
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.2.2...v5.0.0)

---
updated-dependencies:
- dependency-name: pozil/auto-assign-issue
  dependency-version: '2'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
- dependency-name: actions/checkout
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>
…s/github-actions-7128aa616e

chore(ci): bump the github-actions group across 1 directory with 2 updates
Keep beta's changes (ESPHome modernisation, new sensors, actions API)
while preserving main's num_leds fix (1 LED + rmt_symbols: 48).
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b467ea99-8724-4851-8504-a4cdf6f58899

📥 Commits

Reviewing files that changed from the base of the PR and between ebfd77b and 4006638.

📒 Files selected for processing (1)
  • Integrations/ESPHome/MSR-1_BLE.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • Integrations/ESPHome/MSR-1_BLE.yaml

Walkthrough

Updates to GitHub workflow files (action versions, inputs, and auto-assign assignee) and small changes to ESPHome YAMLs (LED strip configuration and logger block relocation).

Changes

Cohort / File(s) Summary
GitHub Workflows
.github/workflows/autoassign.yml, .github/workflows/build.yml, .github/workflows/ci.yml
Bumped pozil/auto-assign-issue from v1v2 and changed assignee to bharvey88; changed firmware-names input from "_Factory:firmware""1_Factory:firmware"; upgraded actions/checkout from v4.2.2v6.0.2.
ESPHome — Core
Integrations/ESPHome/Core.yaml
Changed rgb_light num_leds from 31 and added rmt_symbols: 48.
ESPHome — MSR-1_BLE
Integrations/ESPHome/MSR-1_BLE.yaml
Moved/added a top-level logger: block near esphome.min_version and removed the previous later logger: occurrence (logger now appears at the new location).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

bugfix

Suggested reviewers

  • TrevorSchirmer

Poem

🐰✨ I hopped through pipelines, small and neat,
Bumped versions, nudged a firmware beat,
One LED now glows where three once played,
The logger hopped to where configs are laid,
A tiny rabbit’s fix — quick, bright, and sweet.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the primary purpose: merging main into beta to resolve conflicts, which is confirmed by the PR objectives and all file changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/merge-main-into-beta

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
Integrations/ESPHome/MSR-1_BLE.yaml (1)

23-29: ⚠️ Potential issue | 🟡 Minor

Duplicate logger: block — remove one.

This file now has two top-level logger: keys (lines 23 and 29). YAML mappings must have unique keys; ESPHome/PyYAML will either reject this or silently keep only one, and it diverges from the single-logger: pattern used in MSR-1.yaml and MSR-1_Factory.yaml. Per the PR description, the beta branch already included the logger from main, so the newly added block at line 23 appears to be an unintended merge artifact.

🔧 Proposed fix
   min_version: 2025.2.0

-logger:
-
 dashboard_import:
   package_import_url: github://ApolloAutomation/MSR-1/Integrations/ESPHome/MSR-1_BLE.yaml
   import_full_config: false
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Integrations/ESPHome/MSR-1_BLE.yaml` around lines 23 - 29, Remove the
duplicate top-level "logger:" block that was introduced as a merge artifact so
there is only one logger mapping in the YAML; locate the two occurrences of the
top-level logger key near the "dashboard_import" section and delete the
unintended/extra "logger:" entry (keeping the single logger block consistent
with the pattern used in MSR-1.yaml and MSR-1_Factory.yaml).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@Integrations/ESPHome/MSR-1_BLE.yaml`:
- Around line 23-29: Remove the duplicate top-level "logger:" block that was
introduced as a merge artifact so there is only one logger mapping in the YAML;
locate the two occurrences of the top-level logger key near the
"dashboard_import" section and delete the unintended/extra "logger:" entry
(keeping the single logger block consistent with the pattern used in MSR-1.yaml
and MSR-1_Factory.yaml).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 32a1e025-622a-4ca6-9244-46d9187df37a

📥 Commits

Reviewing files that changed from the base of the PR and between d52f0fe and ebfd77b.

📒 Files selected for processing (5)
  • .github/workflows/autoassign.yml
  • .github/workflows/build.yml
  • .github/workflows/ci.yml
  • Integrations/ESPHome/Core.yaml
  • Integrations/ESPHome/MSR-1_BLE.yaml

Git merge auto-resolved MSR-1_BLE.yaml but left a duplicate logger:
key from main's PR #62 addition alongside beta's existing one.
@TrevorSchirmer TrevorSchirmer merged commit 55b820e into beta Apr 19, 2026
11 checks passed
@TrevorSchirmer TrevorSchirmer deleted the fix/merge-main-into-beta branch April 19, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants