Skip to content

Add real-world confirmation test for the allOf-merge fix #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noha merged 1 commit into from
Aug 1, 2026
Merged

Add real-world confirmation test for the allOf-merge fix #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions source/OpenAPI-Core-Tests/OAExampleDocumentsTests.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,24 @@ OAExampleDocumentsTests >> testPetstoreExpandedIsValid [
self assert: (OADocumentValidator isValidDocument: OAExampleDocuments petstoreExpanded)
]

{ #category : 'tests' }
OAExampleDocumentsTests >> testPetstoreExpandedPetSchemaMergesAllOfBranchesForReading [
"Real-world confirmation: OAExampleDocuments petstoreExpanded's Pet schema is
allOf[$ref NewPet, {required:[id], properties:{id}}] - resolves to JSONSchemaAnyObject.
Reading a response body against it must merge properties/required from BOTH
branches (NewPet contributes name/tag, the inline branch contributes id), not just
pass the raw JSON dictionary through."
| api petSchema result |
api := OpenAPI fromString: OAExampleDocuments petstoreExpanded.
petSchema := api components schemas at: 'Pet'.
result := petSchema readString: '{"id":42,"name":"Rex","tag":"dog"}'.
self assert: result class equals: NeoJSONObject.
self assert: result id equals: 42.
self assert: result name equals: 'Rex'.
self assert: result tag equals: 'dog'.
self should: [ petSchema readString: '{"name":"Rex","tag":"dog"}' ] raise: JSONTypeError
]

{ #category : 'tests' }
OAExampleDocumentsTests >> testPetstoreIsValid [
self assert: (OADocumentValidator isValidDocument: OAExampleDocuments petstore)
Expand Down
Loading