fix(mobile): improve response-viewer readability on phones#142
Open
TeigenZhang wants to merge 1 commit into
Open
fix(mobile): improve response-viewer readability on phones#142TeigenZhang wants to merge 1 commit into
TeigenZhang wants to merge 1 commit into
Conversation
The mobile media query only overrode .response-viewer-body with a flat font-size: 12px / padding: 12px, leaving the desktop response-viewer typography system (--rv-content-max, .rv-text pre, heading scale) with no mobile tuning. Bump body text to 14.5px/1.65, give code blocks phone-sized padding and 11.5px code, scale headings (h1 1.35em / h2 1.2em / h3 1.08em), let content span full width, and cap the panel at 92vh. Layers cleanly on top of the existing response-viewer selectors in styles.css; desktop rendering is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The mobile media query only overrode
.response-viewer-bodywith a flatfont-size: 12px/padding: 12px, leaving the desktop response-viewer typography system (--rv-content-max,.rv-text pre, heading scale defined instyles.css) with no mobile tuning. On phones the transcript read cramped and code/diagrams were unnecessarily tiny.This tunes the existing response-viewer selectors for small screens:
--rv-content-max: 100%)92vhLayers cleanly on top of the existing response-viewer selectors in
styles.css— desktop rendering is unchanged; all changes are scoped inside the mobile media query.Test plan
pre.rv-diagram