Simplify: drop vestigial local re-imports and collapse is_agentic#149
Merged
Conversation
errors.py imports nothing from the package, so the local `from aai_cli.errors import ...` statements inside config.py and context.py functions were pure redundancy shadowing the existing module-level imports (config.py even had three, two within one function, which made CLIError a function-local). Fall back to the module-level imports and collapse is_agentic()'s early-return into a single boolean expression. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
errors.py imports nothing from the package, so the local
from aai_cli.errors import ...statements inside config.py andcontext.py functions were pure redundancy shadowing the existing
module-level imports (config.py even had three, two within one
function, which made CLIError a function-local). Fall back to the
module-level imports and collapse is_agentic()'s early-return into a
single boolean expression.
No behavior change.