Fix CLI QA papercuts: silent --download-sections drop, port bounds, init exit codes#164
Merged
Merged
Conversation
…nit exit codes QA sweep across the command surface surfaced four offline-observable defects: - transcribe: --download-sections was silently dropped for non-URL sources (local file, stdin, remote bucket, directory batch), billing a full-file transcription instead of erroring. Now rejected up front via the existing youtube.validate_sections_flag guard, matching clip/dub. - dev/share/init: an out-of-range --port reached socket.connect_ex and surfaced as an internal "report a bug" error (and for init, only after a wasted scaffold+install). Added min=0/max=65535 bounds so Typer rejects it cleanly before any work. - init: four usage_error raises returned exit 1 while the type's canonical code is 2; converted them to UsageError so error.type maps 1:1 to the exit code. - stream: --min-turn-silence/--max-turn-silence/--inactivity-timeout/--max-tokens accepted 0/negative values; added min=1 to match their range-guarded siblings. Adds boundary tests for each fix and regenerates the affected --help snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA sweep across the command surface surfaced four offline-observable defects:
(local file, stdin, remote bucket, directory batch), billing a full-file
transcription instead of erroring. Now rejected up front via the existing
youtube.validate_sections_flag guard, matching clip/dub.
as an internal "report a bug" error (and for init, only after a wasted
scaffold+install). Added min=0/max=65535 bounds so Typer rejects it cleanly
before any work.
is 2; converted them to UsageError so error.type maps 1:1 to the exit code.
accepted 0/negative values; added min=1 to match their range-guarded siblings.
Adds boundary tests for each fix and regenerates the affected --help snapshots.