Fix release.yml tag job: set git identity for annotated tag#165
Merged
Conversation
The manual workflow_dispatch release path failed at the 'resolve release tag' step with 'fatal: empty ident name … exit code 128'. The job checks out with persist-credentials: false and sets no git identity, but cut_release.sh cuts an annotated tag (git tag -a), which requires a committer identity. Set the github-actions[bot] identity before calling the script, matching what the publish job already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The manual
workflow_dispatchrelease path in.github/workflows/release.ymlfails immediately in theresolve release tagjob:The
tagjob checks out withpersist-credentials: falseand never configures a git identity, butcut_release.shcuts an annotated tag (git tag -a), which requires a committer identity. As a result thebottleandpublishjobs are skipped and no tag/release is produced. This path has never succeeded from CI — it only works locally because maintainers have a global git identity.Observed in run 27485734710.
Fix
Set the
github-actions[bot]git identity in thetagjob before invokingcut_release.sh, mirroring what thepublishjob already does before its commit. Workflow-only change;actionlintclean and the full gate passes.After merge
Dispatch the Release workflow (blank version) to cut v0.1.6 from
main.https://claude.ai/code/session_016ZF4HUbyCpwHH9CG6X6NS3
Generated by Claude Code