-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Implement time tracking for image caption requests #8711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tjc6666666666666
wants to merge
11
commits into
AstrBotDevs:master
Choose a base branch
from
tjc6666666666666:patch-13
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−0
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cf90bde
Implement time tracking for image caption requests
tjc6666666666666 f0cbb7c
Enhance image caption processing with logging and params
tjc6666666666666 978a1bd
Fix formatting issues in group_chat_context.py
tjc6666666666666 fe8b58d
Fix indentation in exception logging
tjc6666666666666 be30eed
Clean up time module imports
tjc6666666666666 aaac393
Refactor model retrieval logic in group_chat_context.py
tjc6666666666666 26aec65
Refactor model retrieval logic in astr_main_agent.py
tjc6666666666666 136808c
Refactor image caption stat recording logic
tjc6666666666666 4b3233b
Implement record_image_caption_stat method
tjc6666666666666 e3b7f5b
Refactor image caption logging and statistics
tjc6666666666666 926c3ca
Update group_chat_context.py
tjc6666666666666 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issues Identified:
provider.text_chatraises an exception (e.g., due to network timeout, API error, etc.), the exception propagates immediately, and the statistics tracking block is bypassed. This means failed requests are never recorded in the database, making error rate calculations impossible.AttributeError: Accessingresponse.usage.input_otherandresponse.roledirectly can raise anAttributeErrorif the provider returns a different structure or if the response is malformed. Usinggetattris a safer, more defensive approach.provider.get_model()is called twice. We can simplify this to a single call.Solution:
Wrap the
provider.text_chatcall in atry...exceptblock to capture any exceptions, record the"error"status in the database, and then re-raise the exception. Usegetattrto safely access response attributes.