Feat/rate limit#11
Merged
Merged
Conversation
razimograbi
reviewed
Jul 2, 2026
razimograbi
left a comment
Collaborator
There was a problem hiding this comment.
Overall good job !
Very clean code
Comment on lines
+31
to
+35
| if (elapsed >= 1) | ||
| { | ||
| globalCount = 0; | ||
| globalWindowStart = now; | ||
| } |
Collaborator
There was a problem hiding this comment.
We reset the global bucket count each second? Why?
Owner
Author
There was a problem hiding this comment.
Because the actual hardware is fast enough to handle a 1-second reset time, with the correct max global traffic per second adjusted, it won't harm the server
razimograbi
approved these changes
Jul 2, 2026
Collaborator
|
Approved |
This reverts commit 6534492.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat/rateLimit
What's in this PR
This PR introduces a full rate limiting layer to protect the server from abusive traffic using the Token Bucket algorithm — the same approach used by Stripe, GitHub, and AWS.
RateLimiter (
src/Limit/Limiter.h/.cpp)Server integration (
src/Server/Server.cpp)acceptClientsbefore any job is handed to the thread poolCloseSocketandcontinue— no worker thread is consumedgetpeername+inet_ntop(cross-platform, works on both Windows and Linux)Unit tests (
src/Tests/test_ratelimiter.cpp)Verified on both Windows (local) and Linux (Docker container)