Skip to content

Add Dashboard nav item; simplify NavHeader#14013

Merged
julianbaker merged 2 commits intomainfrom
dashboard-full-nav-item
Mar 26, 2026
Merged

Add Dashboard nav item; simplify NavHeader#14013
julianbaker merged 2 commits intomainfrom
dashboard-full-nav-item

Conversation

@julianbaker
Copy link
Copy Markdown
Member

@julianbaker julianbaker commented Mar 26, 2026

Introduce a DashboardNavItem component and wire it into the left navigation. Move dashboard link out of the top NavHeader (remove related imports and trackCount hook) and add DashboardNavItem to nav-items index and LeftNav render.

@julianbaker
Add Dashboard nav item; simplify NavHeader
b849fec 
Introduce a DashboardNavItem component and wire it into the left navigation. Move dashboard link out of the top NavHeader (remove related imports and trackCount hook) and add DashboardNavItem to nav-items index and LeftNav render.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: ecfc9a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dylanjeffers
dylanjeffers approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just need to fix web lint

raymondjacobson
raymondjacobson reviewed Mar 26, 2026
View reviewed changes
packages/web/src/components/nav/desktop/NavHeader.tsx Outdated
IconDashboard,
IconSettings
} from '@audius/harmony'
import { Flex, IconAudiusLogoHorizontalNew, IconSettings } from '@audius/harmony'
Copy link
Copy Markdown
Member

@raymondjacobson raymondjacobson Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julianbaker ask your model:

"Please run lint on web and fix the errors"

@julianbaker
Format @audius/harmony imports
ecfc9a6 
Reformat import of Flex, IconAudiusLogoHorizontalNew, and IconSettings from @audius/harmony into a multi-line import in packages/web/src/components/nav/desktop/NavHeader.tsx for improved readability. No functional changes.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

🌐 Web preview ready

Preview URL: https://audius-web-preview-pr-14013.audius.workers.dev

Unique preview for this PR (deployed from this branch).
Workflow run

@julianbaker julianbaker merged commit e23bd39 into main Mar 26, 2026
14 checks passed
@julianbaker julianbaker deleted the dashboard-full-nav-item branch March 26, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobson raymondjacobson raymondjacobson approved these changes

@dylanjeffers dylanjeffers dylanjeffers approved these changes

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@julianbaker @raymondjacobson @dylanjeffers