Skip to content

Fix Linux desktop click: wait_time default and parent-less sibling resolution#701

Merged
mdshakib007 merged 1 commit into
devfrom
linux-click-fixes
Jun 13, 2026
Merged

Fix Linux desktop click: wait_time default and parent-less sibling resolution#701
mdshakib007 merged 1 commit into
devfrom
linux-click-fixes

Conversation

@mahbd

@mahbd mahbd commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • get_path_appname_from_dataset: sanitize the "zeuz_failed" sentinel returned by Get_Shared_Variables before passing the wait time to float(), which previously raised could not convert string to float: 'zeuz_failed'.
  • click_element_by_node: activate/raise the target app's window before performing coord-based AT-SPI mouse / xdotool clicks, since the window may not be in front.
  • resolve_node: when a sibling parameter is given without an explicit parent parameter, locate the sibling's parent in the AT-SPI tree and search for the element among that parent's descendants instead of erroring out.

Test plan

  • Run a Linux desktop click action without an element_wait shared variable set and confirm no float conversion error.
  • Run a click action on an element in a background window and confirm the window is raised before the click.
  • Run a click action using only element parameter + sibling parameter (no parent parameter) and confirm the element is located and clicked.

🤖 Generated with Claude Code

…solution

- get_path_appname_from_dataset: sanitize "zeuz_failed" sentinel from
  Get_Shared_Variables before passing to float()
- click_element_by_node: activate/raise the target app's window before
  coord-based AT-SPI mouse / xdotool clicks
- resolve_node: when a SIBLING is given without an explicit PARENT,
  locate the sibling's parent in the AT-SPI tree and search for the
  element among that parent's descendants
@riz-hossain

Copy link
Copy Markdown
Contributor

🔎 ZeuZ PR Review

Open the full report in ZeuZ: Review findings and apply suggestions

Overview Value
Agents ✅ 4 completed
Suggestions 💡 4

Agent breakdown

→ General Review

Status: ✅ Completed
Suggestions: 1 suggestion

One regression risk stands out: the new parent-less sibling resolution bypasses the configured wait time, which can make otherwise valid clicks fail intermittently. I didn’t find other high-confidence issues from the diff.

→ Security Review

Status: ✅ Completed
Suggestions: 0 suggestions

No security issues found in this PR diff. The changes affect Linux desktop element resolution and click focus handling, but I did not find new injection, authz, secrets, XSS, or path traversal risks.

→ Performance Review

Status: ✅ Completed
Suggestions: 1 suggestion

One performance regression stands out: click_element_by_node now activates the window unconditionally, which adds an extra external process spawn on every click even when the AT-SPI mouse path succeeds.

→ Testing Review

Status: ✅ Completed
Suggestions: 2 suggestions

The PR changes two Linux desktop click resolution paths, but there is no accompanying regression coverage for the new branches or the bug-fix behavior. I’d add focused tests before merging.

Open ZeuZ to inspect full findings, continue an agent conversation, or apply safe patch suggestions.

@mdshakib007 mdshakib007 merged commit cbf6346 into dev Jun 13, 2026
7 checks passed
@mdshakib007 mdshakib007 deleted the linux-click-fixes branch June 13, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants