Fix Linux desktop click: wait_time default and parent-less sibling resolution#701
Conversation
…solution - get_path_appname_from_dataset: sanitize "zeuz_failed" sentinel from Get_Shared_Variables before passing to float() - click_element_by_node: activate/raise the target app's window before coord-based AT-SPI mouse / xdotool clicks - resolve_node: when a SIBLING is given without an explicit PARENT, locate the sibling's parent in the AT-SPI tree and search for the element among that parent's descendants
🔎 ZeuZ PR ReviewOpen the full report in ZeuZ: Review findings and apply suggestions
Agent breakdown→ General ReviewStatus: ✅ Completed One regression risk stands out: the new parent-less sibling resolution bypasses the configured wait time, which can make otherwise valid clicks fail intermittently. I didn’t find other high-confidence issues from the diff. → Security ReviewStatus: ✅ Completed No security issues found in this PR diff. The changes affect Linux desktop element resolution and click focus handling, but I did not find new injection, authz, secrets, XSS, or path traversal risks. → Performance ReviewStatus: ✅ Completed One performance regression stands out: → Testing ReviewStatus: ✅ Completed The PR changes two Linux desktop click resolution paths, but there is no accompanying regression coverage for the new branches or the bug-fix behavior. I’d add focused tests before merging.
|
Summary
get_path_appname_from_dataset: sanitize the"zeuz_failed"sentinel returned byGet_Shared_Variablesbefore passing the wait time tofloat(), which previously raisedcould not convert string to float: 'zeuz_failed'.click_element_by_node: activate/raise the target app's window before performing coord-based AT-SPI mouse / xdotool clicks, since the window may not be in front.resolve_node: when asibling parameteris given without an explicitparent parameter, locate the sibling's parent in the AT-SPI tree and search for the element among that parent's descendants instead of erroring out.Test plan
element_waitshared variable set and confirm nofloatconversion error.element parameter+sibling parameter(noparent parameter) and confirm the element is located and clicked.🤖 Generated with Claude Code