Restore submenus split across responsive navigation variants - #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submenuordropdownnaming tokenscore/navigationtree with nativecore/navigation-submenuchildrenRoot cause
Responsive source sites can split navigation semantics across variants. The visible desktop menu on https://www.carajane.ca carries the top-level Portfolio item, while a duplicate responsive item with the same stable identity owns the Love, Newborn, Family, and Boudoir submenu. Blocks Engine selected the shallow visible variant and did not recognize the richer
menu-wrap > ulstructure as a submenu. Static Site Importer then correctly persisted that incomplete canonical markup.Evidence
core/navigation-linkwith no URL and no children.core/navigation-submenuwith four working local routes.f04c7de7ffb0, Blocks Enginedd78832d48e6.The broader wrapper-heavy authoring model is separate and remains tracked by #868.
Testing
composer test(278 parity fixtures plus canonical, unit, and packaging contracts)mainand this branchAI assistance