fix: validate connection instance in Model.useConnection() (#16098)#16103
Closed
22BRS1317 wants to merge 1 commit intoAutomattic:masterfrom
Closed
fix: validate connection instance in Model.useConnection() (#16098)#1610322BRS1317 wants to merge 1 commit intoAutomattic:masterfrom
22BRS1317 wants to merge 1 commit intoAutomattic:masterfrom
Conversation
Collaborator
|
Closing in favor of #16149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Model.useConnection()only validated that theconnectionargument wasnot
nullorundefined, but accepted any non-nullish value (plain objects,strings, numbers, etc.) without throwing an error. This led to confusing
failures later in the code rather than a clear error at the call site.
Solution
Added an
instanceof Connectioncheck immediately after the existing nullcheck in
lib/model.js. If a non-Connection value is passed, a descriptiveMongooseErroris thrown with the type and value of the invalid argument.Changes
lib/model.js— addedinstanceof Connectionvalidation inModel.useConnection()with a clear error messagetest/model.test.js— added test case inside the existingdescribe('Model.useConnection()')block covering objects,strings, numbers, and null
Test
Fixes #16098