Fix wrong this context in QueryCursor._read cursor close callback#16104
Merged
vkarpov15 merged 1 commit intoAutomattic:masterfrom Mar 17, 2026
Merged
Conversation
Using a regular function in cursor.close() callback caused to be undefined, making error emission fail silently. Changed to arrow function to correctly reference the QueryCursor instance.
Contributor
Author
|
The failing test ( |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates QueryCursor stream end-of-cursor handling to use an arrow function for the cursor.close() callback, ensuring the callback retains the QueryCursor instance context when emitting errors.
Changes:
- Replace
function(error)with(error) => { ... }in thecursor.close()callback within_read()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix wrong
thiscontext inQueryCursor._readcursor close callbackProblem:
In
QueryCursor.prototype._read, thecursor.close()callback used a regularfunction, causingthisto beundefined. This meant any error during cursor close would fail silently instead of being emitted on the QueryCursor instance.Fix:
Changed the regular
functionto an arrow function sothiscorrectly refers to the QueryCursor instance - consistent with howAggregationCursor._readalready handles it.Note:
AggregationCursor._readalready handles this correctly using_this. This PR makesQueryCursorconsistent with that pattern.