Skip to content

Fix ordinary prose redaction - #2359

Merged
chubes4 merged 1 commit into
mainfrom
fix-2137-ordinary-prose-redaction
Aug 24, 2026
Merged

Fix ordinary prose redaction#2359
chubes4 merged 1 commit into
mainfrom
fix-2137-ordinary-prose-redaction

Conversation

@chubes4

@chubes4 chubes4 commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • require explicit : or = delimiters before treating sensitive-looking prose terms as key/value assignments
  • preserve explicit bearer-token redaction while leaving ordinary words such as auth fixture, token validation, and stack-frame at text intact
  • add table-driven regressions pairing harmless prose with real credentials in equivalent assignment, header, bearer, cookie, and JSON contexts

Fixes #2137

Threat model

The previous heuristic accepted whitespace alone as proof that any word containing auth, token, cookie, session, and related fragments introduced a secret. That over-redacted ordinary diagnostics and stack text without adding reliable secrecy: whitespace in prose does not establish a key/value boundary.

This change narrows only that ambiguous fallback. Structured sensitive keys still redact through redactJsonValue; header lines still redact by sensitive header name; query and URL policies remain unchanged; known provider-token shapes remain redacted; explicit sensitive assignments still require redaction; standalone Bearer <credential> remains protected; and artifact redaction still replaces configured secret names and values literally. Output truncation and deterministic ordering are unchanged.

Gates

@chubes4
chubes4 merged commit bee475c into main Aug 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Playground command error smoke redacts ordinary fixture prose

1 participant