Skip to content

Implemented Access Specifier import in Clang#156

Closed
esakellari wants to merge 3 commits into
Axel-Naumann:masterfrom
esakellari:ClangChanges
Closed

Implemented Access Specifier import in Clang#156
esakellari wants to merge 3 commits into
Axel-Naumann:masterfrom
esakellari:ClangChanges

Conversation

@esakellari
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not:

if (CXXRecordDecl* ToDecl = dyn_cast<CXXRecordDecl>(Importer.Import(T->getDecl())
  Importer.getToContext().getTagDeclType(ToDecl);
return QualType();

@Axel-Naumann
Copy link
Copy Markdown
Owner

Can you add a test?
Can you (re-) check that this doesn't extend beyond 80 columns?
Otherwise: Vassil says it's fine!

@Axel-Naumann
Copy link
Copy Markdown
Owner

Superseded by PR #157 #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants