Skip to content

add NFT Trading bridge#305

Open
liusanchuan wants to merge 29 commits into
AztecProtocol:masterfrom
liusanchuan:nft-trading-bridge
Open

add NFT Trading bridge#305
liusanchuan wants to merge 29 commits into
AztecProtocol:masterfrom
liusanchuan:nft-trading-bridge

Conversation

@liusanchuan
Copy link
Copy Markdown

Description

Add the Specs of My NFT trading bridge.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • There are no unexpected formatting changes, or superfluous debug logs.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewers next convenience.
  • NatSpec documentation of all the non-test functions is present and is complete.
  • Continuous integration (CI) passes.
  • Command forge coverage --match-contract MyContract returns 100% line coverage.
  • All the possible reverts are tested.

@liusanchuan liusanchuan marked this pull request as ready for review January 6, 2023 05:34
@liusanchuan liusanchuan changed the title add specs add NFT Trading bridge Jan 6, 2023
liusanchuan and others added 24 commits January 6, 2023 22:45
* style: updated formatting

* fix: Bump liquity gas bounds

Co-authored-by: LHerskind <lasse.herskind@gmail.com>
* feat: add element deployment + update workaround

* fix: remapping + clarity improvement data provider deployment

* fix: formatting

* fix: Add missing broadcast in element deployment s

* fix: we be formatting

Co-authored-by: cheethas <sean.cheetham1@gmail.com>
* feat: listing erc4626 subsidies

* feat: finished listing erc4626 subsidies

* feat: yearn subsidy listing + list all flag

* feat: ERC4626 tags

* feat: displaying cost estimation for a month

* refactor: improved naming

* feat: getting info from env

* fix: use log instead of list

* fix: spelling

* fix: use decimals for easier read

* fix: print constants used

Co-authored-by: LHerskind <lasse.herskind@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants