docs: CustomData size guard design for hotfix PRs - #9181
Closed
Abigail Liang (abigailliang-aks-sig-node) wants to merge 1 commit into
Closed
docs: CustomData size guard design for hotfix PRs#9181Abigail Liang (abigailliang-aks-sig-node) wants to merge 1 commit into
Abigail Liang (abigailliang-aks-sig-node) wants to merge 1 commit into
Conversation
Design doc for pre-deployment validation of CustomData and protectedSettings size limits during hotfix injection.
Abigail Liang (abigailliang-aks-sig-node)
requested review from
Chou Hu (AbelHu),
Devinwong,
Sri Harsha (SriHarsha001),
Nishchay (awesomenix),
Calvin S. (calvin197),
Cameron Meissner (cameronmeissner),
Sylvain Boily (djsly),
Ganeshkumar Ashokavardhanan (ganeshkumarashok),
Karen Chen (karenychen),
lilypan26,
Mark Ibrahim (mxj220),
Peter Damianov (pdamianov-dev),
Patrick W. Healy (phealy),
r2k1,
Runzhen (runzhen),
sulixu,
Tim Wright (timmy-wright),
Thibault Cohen (titilambert),
Xu Xue (xuexu6666) and
Zachary (zachary-bailey)
as code owners
August 11, 2026 23:20
Contributor
PR Title Lint Failed ❌Current Title: Your PR title doesn't follow the expected format. Please update your PR title to follow one of these patterns: Conventional Commits Format:
Guidelines:
Examples:
Please update your PR title and the lint check will run again automatically. |
Copilot started reviewing on behalf of
Abigail Liang (abigailliang-aks-sig-node)
August 11, 2026 23:20
View session
Contributor
Author
|
Superseded — reopening from the branch that includes the full implementation. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a design document describing a proposed CI guardrail to prevent Linux hotfix PRs from causing VMSS CustomData/protectedSettings size overflows during provisioning, as an interim solution until hotfix scripts are embedded in aks-node-controller (#9101).
Changes:
- Introduces a design doc explaining the CustomData (87,380 base64 bytes) and protectedSettings (~65,535 bytes) constraints and why both must be guarded independently.
- Documents a proposed approach (Go tests + CI wiring) to validate worst-case sizes after hotfix generation.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+103
to
+107
| ## 5. Two Guards (Implemented) | ||
|
|
||
| Investigation of the Mode B fallback revealed that **H and R end up in different Azure fields**, so a single CustomData check is insufficient. Two independent guards are implemented in | ||
| `pkg/agent/customdata_size_guard_test.go` (plain `Test*` funcs so they run under `go test -run`). | ||
|
|
Comment on lines
+193
to
+195
| | `pkg/agent/baker.go:145-227` | `getLinuxNodeBootstrappingPayload` + `getScriptlessBoothook` | | ||
| | `pkg/agent/baker.go:29` | `MaxCustomDataLength = 87380` | | ||
| | `pkg/agent/const.go:105,122` | hotfix JSON file paths | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hotfix-generate.ymlto fail hotfix PRs that would exceed limitsContext
This is a bridge solution until PR #9101 (embed hotfix scripts in ANC binary) lands.
Test plan