Bump typescript from 5.9.3 to 7.0.2 - #2698
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the project’s TypeScript toolchain dependency version.
Changes:
- Bumps the
typescriptdevDependency from^5.0.3to^7.0.2.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
03aa34c to
db11332
Compare
|
@dependabot rebase |
|
Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
db11332 to
d811e9c
Compare
d811e9c to
c68cae4
Compare
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.9.3 to 7.0.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](https://github.com/microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: typescript dependency-version: 7.0.2 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
c68cae4 to
356f9ca
Compare
|
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Fixed in commit above:
Self-rating: 7/10. The build/lint fix works and is verified, but it's a workaround (dual TS install) rather than a clean single-version upgrade, since typescript-eslint doesn't support TS7 yet. I did not run the entire test suite end-to-end due to time constraints, only representative suites. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
package.json:89
@typescript-eslint/*in this lockfile declares atypescriptpeer dependency of>=4.8.4 <6.1.0(see package-lock). Using^6.0.3allows npm to resolve to6.1.0+later, which would violate that constraint and can break installs/linting. Consider pinning TypeScript to the 6.0.x line (e.g.~6.0.3or an exact6.0.3) while it’s being used for@typescript-eslint.
"typescript": "npm:typescript@^6.0.3",
"typescript-for-build": "npm:typescript@^7.0.2",
ChangeLog.md:19
- This changelog entry claims
"types": ["*"]restores automatic@typesinclusion, butcompilerOptions.typesdoesn’t support wildcards. This should be reworded to avoid suggesting an invalid tsconfig setting and to describe the correct approach (omittypesto keep default auto-inclusion, or list specific type packages).
- Bumped `typescript` dev dependency from 5.9.3 to 7.0.2 for the main build, while keeping a TypeScript 6.x install (aliased as the `typescript` package) for `@typescript-eslint`, which does not yet support TypeScript 7. Updated `tsconfig.json` to remove compiler options removed in TypeScript 7 (`moduleResolution: "node"`, `downlevelIteration`) and to explicitly set `"types": ["*"]` to restore the previous automatic inclusion of `@types` packages (e.g. mocha, node) required by test files.
|
@copilot, please review and validate any comments that are there. |
Re-validated the changes: |
@copilot, have you also verified these 2 suppressed comments. |
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
... Yes, both suppressed comments were valid and I missed them earlier — I focused on verifying build/lint/test success rather than re-reading the suppressed Copilot review comments on the diff itself. Fixed in
Re-verified |
Bumps typescript from 5.9.3 to 7.0.2.
Release notes
Sourced from typescript's releases.
Commits
Maintainer changes
This version was pushed to npm by microsoft1es, a new releaser for typescript since your current version.