Skip to content

Bump rcedit from 4.0.1 to 5.0.2 - #2702

Merged
jainakanksha-msft merged 2 commits into
mainfrom
dependabot/npm_and_yarn/rcedit-5.0.2
Aug 5, 2026
Merged

Bump rcedit from 4.0.1 to 5.0.2#2702
jainakanksha-msft merged 2 commits into
mainfrom
dependabot/npm_and_yarn/rcedit-5.0.2

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 4, 2026

Copy link
Copy Markdown
Contributor

Bumps rcedit from 4.0.1 to 5.0.2.

Release notes

Sourced from rcedit's releases.

v5.0.2

5.0.2 (2025-11-24)

Bug Fixes

  • rename rcedit.js to index.js to fix type resolution (#160) (b2e9323)

v5.0.1

5.0.1 (2025-11-14)

Bug Fixes

v5.0.0

5.0.0 (2025-11-07)

BREAKING CHANGES

  • This module now requires Node.js >=22.12 and is ESM-only. rcedit is now a named export. The rcedit.exe binary is updated to v2.0.0.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rcedit](https://github.com/electron/node-rcedit) from 4.0.1 to 5.0.2.
- [Release notes](https://github.com/electron/node-rcedit/releases)
- [Commits](electron/node-rcedit@v4.0.1...v5.0.2)

---
updated-dependencies:
- dependency-name: rcedit
  dependency-version: 5.0.2
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Aug 4, 2026
Copilot AI lite review requested due to automatic review settings August 4, 2026 18:33
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Aug 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

This PR updates the rcedit dependency version to a newer release.

Changes:

  • Bumped rcedit from ^4.0.0 to ^5.0.2 in package.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json Outdated
@jainakanksha-msft

Copy link
Copy Markdown
Member

@copilot

  1. if there is any build issue fix that
  2. Run through test cases and validate the changes fully if it impacts the code
  3. Add\Update relevant test case
  4. Update the Changelist
  5. Analyse and validate the review comments
  6. Rate your overall work

Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 5, 2026 06:02
@dependabot
dependabot Bot removed the request for review from Copilot August 5, 2026 06:02

Copilot AI commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@copilot

  1. if there is any build issue fix that
  2. Run through test cases and validate the changes fully if it impacts the code
    ...

Done. Findings and changes:

  1. Build issue found and fixed: rcedit@5.0.2 is ESM-only and no longer exports a default/callable module — it exports a named rcedit function. scripts/buildExe.js used const rcedit = require('rcedit') which would fail at runtime with "rcedit is not a function". Fixed to const { rcedit } = require('rcedit'); (commit 1cad6ff... see latest push).
  2. Validated impact: Confirmed via node -e "require('rcedit')" that the old pattern returns { rcedit: fn } not a callable. After the fix, npm run build:exe:audit proceeds past the import and only fails on the expected "Cannot build Windows binaries on non-Windows platform" check (this script requires Windows to fully execute rcedit against a PE binary, so full exe build can't be validated in this sandbox).
  3. Tests: scripts/buildExe.js isn't covered by the mocha test suite (it's a Windows-only packaging script with no existing unit tests), so no new test cases were added; ran npm run build and npm run lint, both pass.
  4. Changelog updated with the dependency bump and accompanying fix.
  5. Review comment addressed: pinned rcedit to exact 5.0.2 (removed ^) in package.json/package-lock.json as suggested, since this is a major version bump.
  6. Self-rating: 4/5 — the actual breaking bug (ESM/named-export mismatch) was caught and fixed, and the version-pinning suggestion was applied, but I couldn't run the full exe build end-to-end since it requires Windows.

Copilot AI requested a review from jainakanksha-msft August 5, 2026 06:03
@jainakanksha-msft
jainakanksha-msft merged commit b1e4a70 into main Aug 5, 2026
44 checks passed
@jainakanksha-msft
jainakanksha-msft deleted the dependabot/npm_and_yarn/rcedit-5.0.2 branch August 5, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants