Ensure regenerated modular package.json includes @azure/core-util runtime dependency#3996
Open
Copilot wants to merge 2 commits into
Open
Ensure regenerated modular package.json includes @azure/core-util runtime dependency#3996Copilot wants to merge 2 commits into
@azure/core-util runtime dependency#3996Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/Azure/autorest.typescript/sessions/d24803f5-d936-4928-9fa3-20954af053b4 Co-authored-by: jeremymeng <7583839+jeremymeng@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing @azure/core-util dependency in generated code
Ensure regenerated modular package.json includes May 21, 2026
@azure/core-util runtime dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some generated modular clients import
uint8ArrayToString/stringToUint8Arrayfrom@azure/core-util, but the migration/update path for existingpackage.jsondid not guarantee that dependency was added.Problem scope
updatePackageFile-based regeneration could miss runtime deps required by generated models/helpers.Generator update: include
@azure/core-utilin modular update flowpackages/typespec-ts/src/index.tsso modular package updates add@azure/core-util(Azure flavor) in the same dependency bundle used during package migration updates.Package updater enhancement: merge caller-provided dependencies
packages/rlc-common/src/metadata/buildPackageFile.ts:updatePackageFile(...)now acceptsdependenciesin options.packageInfo.dependenciesinstead of ignoring them.Focused regression coverage
packages/rlc-common/test/integration/packageJson.spec.tsverifyingupdatePackageFile(...)preserves existing deps and merges new ones like@azure/core-util.