{CI} Make raw request header test Accept-Encoding resilient#33316
Merged
{CI} Make raw request header test Accept-Encoding resilient#33316
Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vm host show | cmd vm host show update parameter expand: updated property choices from ['instanceView', 'resiliencyView', 'userData'] to ['instanceView', 'userData'] |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
requested review from
Pan-Qi,
bebound,
jiasli,
jsntcy,
kairu-ms,
wangzelin007 and
yonzhan
microsoft-github-policy-service
Bot
added
Auto-Assign
YangAn-microsoft
changed the title
YangAn-microsoft
requested review from
DanielMicrosoft,
ReaNAiveD,
isra-fel,
necusjz,
notyashhh,
teresaritorto and
xuming-ms
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure CLI core test suite to make test_send_raw_requests resilient to runtime- and dependency-specific variations in the default Accept-Encoding header (e.g., Python 3.14 adding zstd), while keeping strict verification for CLI-controlled headers and request composition.
Changes:
- Added a test helper to assert
Accept-Encodingcontains required encodings (gzip,deflate) without requiring an exact string match. - Replaced strict full-header dict equality assertions in
test_send_raw_requestswith the new helper to avoid brittleness across runtimes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
necusjz
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
test_send_raw_requeststo avoid asserting an exactAccept-Encodingstring, which varies by runtime/compression support (for example Python 3.14 addszstd).Root cause
requests/urllib3now compute defaultAccept-Encodingbased on available codecs.On Python 3.14,
compression.zstdis available, so default headers includezstd, causing strict header dict equality checks to fail.What changed
Accept-Encodingcontains required values (gzip,deflate)test_send_raw_requestswith the helperWhy this is correct
This keeps strict validation of CLI-owned behavior (
User-Agent, telemetry headers, auth headers, URL/body handling) while removing brittle coupling to dependency/runtime-specific transport defaults.Validation
python -m pytest src/azure-cli-core/azure/cli/core/tests/test_util.py -k test_send_raw_requests -qpython -m pytest src/azure-cli-core/azure/cli/core/tests/test_util.py -k test_send_raw_requests -q