[Appservice] az functionapp create: Auto-register Microsoft.App provider for Flex Consumption apps#33331
Draft
[Appservice] az functionapp create: Auto-register Microsoft.App provider for Flex Consumption apps#33331
az functionapp create: Auto-register Microsoft.App provider for Flex Consumption apps#33331Conversation
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
microsoft-github-policy-service
Bot
requested review from
jsntcy,
wangzelin007,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
Bot
added
ARM
microsoft-github-policy-service
Bot
added
Portal
… app creation Agent-Logs-Url: https://github.com/Azure/azure-cli/sessions/6d1391c2-c0c3-48a2-b291-73e03af3a13c Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Azure CLI to enforce Microsoft.App resource provider registration
[Appservice] May 8, 2026
az functionapp create: Auto-register Microsoft.App provider for Flex Consumption apps
a0x1ab
approved these changes
May 8, 2026
Member
a0x1ab
left a comment
a0x1ab
left a comment
There was a problem hiding this comment.
🤖 AI Agent | This comment was posted automatically by the GitHub Copilot agent assist loop.
✅ Reviewer — PR #33331 Code Review Passed
Issue: #33177 — Flex Consumption Function App creation does not enforce Microsoft.App resource provider registration
Code Review Results
Changes in custom.py (3 lines):
- ✅
--planpath:if plan_info.sku and plan_info.sku.tier and plan_info.sku.tier.lower() == 'flexconsumption': register_app_provider(cmd)— safe None-guards before attribute access, case-insensitive comparison - ✅
--flexconsumption-locationpath:register_app_provider(cmd)moved to run unconditionally after location validation, not just inside VNet block
Tests in test_functionapp_commands_thru_mock.py (181 lines, 4 scenarios):
- ✅
--flexconsumption-locationwithout VNet →register_app_providercalled once - ✅
--flexconsumption-locationwith VNet →register_app_providercalled - ✅
--planwithFlexConsumptiontier →register_app_providercalled once - ✅
--planwithStandardtier →register_app_providernot called
Note: Azure VM-based testing was blocked (no credentials in agent environment). CI checks were in-progress at review time — please verify all checks pass before merging. PR is currently a draft.
Collaborator
|
Appservice |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az functionapp createDescription
When creating a Flex Consumption Function App,
Microsoft.Appresource provider was never registered — even though the portal and CLI are documented to enforce this. The missing registration causes failures later when enabling VNet integration withMicrosoft.App/environmentssubnet delegation.Changes:
--flexconsumption-locationpath:register_app_provider(cmd)is now called unconditionally in theelif flexconsumption_location:branch. Previously it was only called from within the VNet integration block, leaving non-VNet creation paths unregistered.--planpath with FlexConsumption SKU:register_app_provider(cmd)is now called when the resolved plan hassku.tier == 'FlexConsumption', covering users who pass an existing FC1 plan via--plan.Testing Guide
Unit tests added in
test_functionapp_commands_thru_mock.py::TestCreateFunctionAppFlexProviderRegistration:# Run the new unit tests python -m pytest src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_functionapp_commands_thru_mock.py::TestCreateFunctionAppFlexProviderRegistration -vCovers:
--flexconsumption-locationwithout VNet → provider registered--flexconsumption-locationwith VNet → provider registered--planwith FlexConsumption tier → provider registered--planwith non-FlexConsumption tier → provider not registeredHistory Notes
[Appservice]
az functionapp create: Auto-registerMicrosoft.Appresource provider when creating Flex Consumption function apps to prevent later VNet integration failuresThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
azcliprod.blob.core.windows.net/usr/bin/python python -m pytest src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_functionapp_commands_thru_mock.py::TestCreateFunctionAppFlexProviderRegistration -v(dns block)If you need me to access, download, or install something from one of these locations, you can either: