[POSTGRESQL] BREAKING CHANGE: az postgres flexible-server backup create: Remove backup name requirement and implement automatic name generation for backups#33340
Open
mattboentoro wants to merge 1 commit intoAzure:devfrom
Conversation
…ate`: Remove backup name requirement and implement automatic name generation for backups
mattboentoro
requested review from
Pan-Qi,
VeryEarly,
calvinhzy and
jsntcy
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| postgres flexible-server backup create | cmd postgres flexible-server backup create removed property deprecate_info_target |
||
| postgres flexible-server backup create | cmd postgres flexible-server backup create update parameter backup_name: removed property required=True |
||
| postgres flexible-server create | cmd postgres flexible-server create added parameter create_cluster |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
wangzelin007,
yonzhan and
zhoxing-ms
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PostgreSQL flexible server backup create flow to make the backup name optional by generating a default name when omitted, and adjusts PostgreSQL breaking-change registrations accordingly.
Changes:
- Added automatic on-demand backup name generation when no backup name is provided.
- Updated
backup_create_functo accept an optionalbackup_nameand log the generated name. - Removed a now-obsolete breaking-change notice specific to
backup createin the PostgreSQL module.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/postgresql/commands/backup_commands.py |
Adds backup name auto-generation and makes backup_name optional in backup_create_func. |
src/azure-cli/azure/cli/command_modules/postgresql/_breaking_change.py |
Removes a breaking-change registration related to backup name requirement for backup create. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server backup create
Description
Remove backup name requirement and implement automatic name generation for backups
Testing Guide
History Notes
[POSTGRESQL] BREAKING CHANGE:
az postgres flexible-server backup create: Remove backup name requirement and implement automatic name generation for backupsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.