{Misc.} Add Identity Squad to CODEOWNERS#33399
Merged
Merged
Conversation
...of the dependency manifest
️✔️AzureCLI-FullTest
|
|
Hi @isra-fel, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates repository ownership routing by adding @MaddyMicrosoft (Identity squad) to CODEOWNERS entries covering azure-cli-core and several identity-related command modules, plus explicitly adding owners for dependency-related files.
Changes:
- Add
@MaddyMicrosoftto multiple existing CODEOWNERS patterns underazure-cli-coreand several command modules (e.g.,identity,keyvault,profile,role). - Add explicit CODEOWNERS entries for
/src/azure-cli-core/setup.pyand/src/azure-cli/requirements.*.txt.
Comments suppressed due to low confidence (1)
.github/CODEOWNERS:27
/src/azure-cli-core/setup.pyis already covered by the broader/src/azure-cli-core/rule above with the exact same owner list, so this line is redundant and can drift over time. Consider removing it, or (if you intended a different ownership just forsetup.py) adjust the owner list accordingly and keep it grouped with the otherazure-cli-coreentries for easier maintenance.
/src/azure-cli/ @necusjz @DanielMicrosoft @ReaNAiveD @yonzhan @bebound @jiasli
/src/azure-cli-core/setup.py @necusjz @DanielMicrosoft @ReaNAiveD @yonzhan @bebound @jiasli @isra-fel @MaddyMicrosoft @notyashhh @xuming-ms @teresaritorto
/src/azure-cli/requirements.*.txt @necusjz @DanielMicrosoft @ReaNAiveD @yonzhan @bebound @jiasli @isra-fel @MaddyMicrosoft @notyashhh @xuming-ms @teresaritorto
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
+19
| /src/azure-cli-core/ @necusjz @DanielMicrosoft @ReaNAiveD @yonzhan @bebound @jiasli @isra-fel @MaddyMicrosoft @notyashhh @xuming-ms @teresaritorto | ||
| /src/azure-cli-core/azure/cli/core/_profile.py @isra-fel @MaddyMicrosoft @notyashhh @xuming-ms @teresaritorto | ||
| /src/azure-cli-core/azure/cli/core/auth/ @isra-fel @MaddyMicrosoft @notyashhh @xuming-ms @teresaritorto | ||
| /src/azure-cli-core/azure/cli/core/cloud.py @isra-fel @MaddyMicrosoft @notyashhh @xuming-ms @teresaritorto |
necusjz
approved these changes
May 20, 2026
necusjz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...of the dependency manifest
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.