[AKS] Skip subnet validation for existing outbound type on update#33418
Open
wenhug wants to merge 1 commit into
Open
[AKS] Skip subnet validation for existing outbound type on update#33418wenhug wants to merge 1 commit into
wenhug wants to merge 1 commit into
Conversation
wenhug
requested review from
FumingZhang,
NoriZC,
teresaritorto and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @wenhug, |
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
added
Auto-Assign
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adjusts outbound type validation so update scenarios that read outbound_type from the existing ManagedCluster don’t incorrectly require --vnet-subnet-id, and adds a regression test for that case.
Changes:
- Skip the “missing vnet subnet” validation when
outbound_typeis sourced from the existingmcobject. - Add a unit test covering
userAssignedNATGatewayoutbound type with no vnet subnet in UPDATE mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py | Adds a regression test ensuring UPDATE mode can read outbound_type from mc without requiring a subnet. |
| src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py | Updates outbound type validation logic to skip subnet requirement when the value is read from the existing cluster. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
| ctx_14_0 = AKSManagedClusterContext( | ||
| self.cmd, | ||
| AKSManagedClusterParamDict({"sku": "base"}), |
Comment on lines
+2482
to
2483
| if not read_from_mc and self.get_vnet_subnet_id() in ["", None] and not byo_subnets_set: | ||
| self._raise_missing_vnet_subnet_for_outbound_type(outbound_type, skuName) |
FumingZhang
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
python3 -m pytest src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py -k 'test_get_outbound_type or test_update_outbound_type' -q\n -2 passed, 266 deselected