[Storage] `az storage account: New features for 2025-08-01#33423
Open
calvinhzy wants to merge 5 commits into
Open
[Storage] `az storage account: New features for 2025-08-01#33423calvinhzy wants to merge 5 commits into
calvinhzy wants to merge 5 commits into
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @calvinhzy, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| storage account blob-service-properties update | cmd storage account blob-service-properties update added parameter default_index_document_path |
||
| storage account blob-service-properties update | cmd storage account blob-service-properties update added parameter enable_static_website |
||
| storage account blob-service-properties update | cmd storage account blob-service-properties update added parameter error_document_404_path |
||
| storage account blob-service-properties update | cmd storage account blob-service-properties update added parameter index_document |
||
| storage account create | cmd storage account create added parameter allowed_copy_scope |
||
| storage account or-policy create | cmd storage account or-policy create added parameter tags_replication |
||
| storage account or-policy update | cmd storage account or-policy update added parameter tags_replication |
||
| storage account update | cmd storage account update added parameter allowed_copy_scope |
microsoft-github-policy-service
Bot
added
Storage
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
calvinhzy
changed the title
az storage account create/update: New features for 2025-08-01…atic-website`, `--index-document`, `--default-index-document-path`, `--error-document-404-path`
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Azure Storage Account command support for new 2025-08-01-era features and updates scenario coverage/recordings accordingly.
Changes:
- Add
--allowed-copy-scopetoaz storage account create/update. - Extend
storage account blob-service-properties updatewith static website parameters. - Add
--tags-replicationsupport tostorage account or-policy create/updateand update scenario tests/recordings (including new Smart access tier coverage).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/storage/operations/account.py | Implements allowed_copy_scope, static website updates for blob service properties, and tags replication for OR policy create/update. |
| src/azure-cli/azure/cli/command_modules/storage/_params.py | Wires new CLI arguments for allowed copy scope, static website options, and tags replication. |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/test_storage_account_scenarios.py | Adds/updates scenario tests for Smart tier, allowed copy scope, static website, and tags replication; updates ORS test region. |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/recordings/test_storage_account_static_website.yaml | New recording for static website scenario test. |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/recordings/test_storage_account_smart_tier.yaml | New recording for Smart access tier scenario test. |
| src/azure-cli/azure/cli/command_modules/storage/tests/latest/recordings/test_storage_account_allowed_copy_scope.yaml | New recording for allowed copy scope scenario test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1137
to
+1144
| or_policy = ObjectReplicationPolicy(source_account=properties.get('sourceAccount'), | ||
| destination_account=properties.get('destinationAccount'), | ||
| rules=rules, | ||
| metrics=ObjectReplicationPolicyPropertiesMetrics(enabled=properties.get('metrics').get('enabled')), | ||
| priority_replication=ObjectReplicationPolicyPropertiesPriorityReplication( | ||
| enabled=properties.get('priorityReplication').get('enabled'))) | ||
| enabled=properties.get('priorityReplication').get('enabled')), | ||
| tags_replication=ObjectReplicationPolicyPropertiesTagsReplication( | ||
| enabled=properties.get('tagsReplication').get('enabled'))) |
Comment on lines
1185
to
+1193
| parameters = ObjectReplicationPolicy(source_account=properties.get('sourceAccount'), | ||
| destination_account=properties.get('destinationAccount'), | ||
| rules=rules, | ||
| metrics=ObjectReplicationPolicyPropertiesMetrics( | ||
| enabled=properties.get('metrics').get('enabled')), | ||
| priority_replication=ObjectReplicationPolicyPropertiesPriorityReplication( | ||
| enabled=properties.get('priorityReplication').get('enabled'))) | ||
| enabled=properties.get('priorityReplication').get('enabled')), | ||
| tags_replication=ObjectReplicationPolicyPropertiesTagsReplication( | ||
| enabled=properties.get('tagsReplication').get('enabled'))) |
Comment on lines
+972
to
+977
| if enable_static_website is not None or index_document or default_index_document_path or error_document_404_path: | ||
| StaticWebsite = cmd.get_models('StaticWebsite') | ||
| instance.static_website = StaticWebsite(enabled=enable_static_website, | ||
| index_document=index_document, | ||
| default_index_document_path=default_index_document_path, | ||
| error_document404_path=error_document_404_path) |
Comment on lines
+737
to
+744
| c.argument('index_document', arg_group='Static Website', | ||
| help='The webpage that Azure Storage serves for requests to the root of a website or any subfolder ' | ||
| '(for example, index.html).') | ||
| c.argument('default_index_document_path', arg_group='Static Website', | ||
| options_list=['--default-index-document-path', '--default-index'], | ||
| help='The absolute path where the default index file is present. This absolute path is mutually ' | ||
| 'exclusive to "indexDocument" and it is case-sensitive.') | ||
| c.argument('error_document_404_path', arg_group='Static Website', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Storage]
az storage account create/update: Support new valueSmartfor--access-tier[Storage]
az storage account create/update: Support--allowed-copy-scope[Storage]
az storage account blob-service-properties update: Add--enable-static-website,--index-document,--default-index-document-path,--error-document-404-path[Storage]
az storage account or-policy create/update: Add--tags-replicationThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.